Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
general-topic
Huge Smileys
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Apr 24, 2015 - 3:25 pm

And I say... well I wont tell you what I said under my breath....
Not sure how that combination got missed by missed it was. Back to the drawing board I am afraid. The good news is that when we get the fix it will work retrospectively. I think....

andy-signature.png
YELLOW
SWORDFISH
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Apr 24, 2015 - 4:52 pm

Would you be willing to make a small edit to an existing core file?

andy-signature.png
YELLOW
SWORDFISH
Avatar
kvr28
Member
Free Members
sp_UserOfflineSmall Offline
Apr 24, 2015 - 7:49 pm

Sure, I can do that

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Apr 24, 2015 - 11:18 pm

I believe I know what Andy wants you to do, but at this point, I think I will just wait the few hours until he is back around...

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Apr 25, 2015 - 3:10 am

The file in question is /simple-press/sp-api/sp-api-filters.php

It is, I am afraid, a big file. The biggest in core I believe. You are looking for a function called:

sp_format_display_image()

which is about two-thirds of the way through the file at line number 1318.

Pretty near the top if the function are these lines of code:

# is any of this needed?
 if ($sfimage['enlarge'] == false && $sfimage['process'] == false) return $match[0];
$thumb = $sfimage['thumbsize'];
 if ((empty($thumb)) || ($thumb < 100)) $thumb = 100;

These lines need to be moved beneath the block of code just a little fiurther down that is:

# is this a smiley?
 if ((strpos($src[1], 'plugins/emotions')) || (strpos($src[1], $spPaths['smileys']))) {
    return str_replace('img ', 'img class="spSmiley" style="margin:0"', $match[0]);
 } elseif (strpos($src[1], 'images/smilies')) {
    return str_replace('class="spSmiley"', 'class="spWPSmiley" style="max-height:1em;margin:0"', $match[0]);
 }

So put the first section of code AFTER this second section and I believe all should be well. I am torn between thinking SP has too many option settings and thinking it has what it needs. But I do know the more there are then the more complex the testing has to be to cover all the permutations and I am sorry we missed this one.

andy-signature.png
YELLOW
SWORDFISH
Avatar
kvr28
Member
Free Members
sp_UserOfflineSmall Offline
Apr 25, 2015 - 9:15 am

I'll give it a shot

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Apr 25, 2015 - 10:35 am

Thanks

andy-signature.png
YELLOW
SWORDFISH
Avatar
kvr28
Member
Free Members
sp_UserOfflineSmall Offline
Apr 25, 2015 - 10:59 am

it appears to have fixed it on my staging server

http://kvr28.staging.wpengine......es/page-5/

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Apr 25, 2015 - 11:12 am

good news... thanks for confirming the fix...

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 643
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 616
Members: 17343
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10117
Posts: 79590