Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
general-topic
Thanks Plugin
Avatar
Ike
Sawtry, UK
Member
Free Members
sp_UserOfflineSmall Offline
Feb 25, 2015 - 6:45 pm

The CSS I posted on the first page to fix font colour, I'm just saying it should be 'color' not 'font-color', so it should be:

#spMainContainer .spTopicViewSection {
    color: #000000;
}

And I would probably put it at the very end of the stylesheet (reboot.php) along with all the other CSS - before the ending PHP.

Avatar
Alex T
Member
sp_UserOfflineSmall Offline
Feb 25, 2015 - 7:07 pm

These are the very last things in reboot.php

# load mobile overrides
if ($viewDevice == 'mobile') {
include('reboot-mobile.php');
}

# load the rtl css file if needed
if (isset($_GET['rtl'])) {
include('reboot-rtl.php');
}

?

If I put that code before the ?, then all the formatting gets lost.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Feb 26, 2015 - 3:50 am

As Ike said - before the php at the end. That means just before the opening php tag (<?php)

andy-signature.png
YELLOW
SWORDFISH
Avatar
Alex T
Member
sp_UserOfflineSmall Offline
Feb 26, 2015 - 10:42 am

Yellow Swordfish said
As Ike said - before the php at the end. That means just before the opening php tag (<?php)

Sorry but this does not mean much to me.  I'm not a coder so I don't understand the technical speak.  I can get by with you telling me where exactly to place things.  Does this mean at the very top of reboot.php?

Above this?

<?php
header("Content-Type: text/css; charset: utf-8");
header("Expires: ".gmdate('D, d M Y H:i:s', (time()+900)) . " GMT");
Avatar
Ike
Sawtry, UK
Member
Free Members
sp_UserOfflineSmall Offline
Feb 26, 2015 - 11:01 am

Sorry, maybe we haven't explained properly!

You have CSS and PHP in the stylesheet (reboot.php) and you can't have any CSS inside the PHP sections.

General rule is that a PHP section starts with    '<?php'     and ends with     '?>'

At the very bottom of reboot.php you have:

/* ----------------------
Mobile overrides misc
-------------------------*/

@media screen and (max-width: 379px)  {
    #spMainContainer #spLastVisitLabel {
        display: none;
    }
}

<?php

# Load plugin file css (as .spcss files)
foreach (glob("*.spcss") as $f) {
    include $f;
}

# load mobile overrides
if ($viewDevice == 'mobile') {
    include('reboot-mobile.php');
}

# load the rtl css file if needed
if (isset($_GET['rtl'])) {
    include('reboot-rtl.php');
}

?>

As you can see the last CSS rule is a mobile rule, then the CSS ends and the PHP starts. I would place it after the last closing brace '}' and before the opening PHP tag '<?php' on line 11 of the below example - see:

/* ----------------------
Mobile overrides misc
-------------------------*/

@media screen and (max-width: 379px)  {
    #spMainContainer #spLastVisitLabel {
        display: none;
    }
}

<--- PLACE HERE

<?php

# Load plugin file css (as .spcss files)
foreach (glob("*.spcss") as $f) {
    include $f;
}

# load mobile overrides
if ($viewDevice == 'mobile') {
    include('reboot-mobile.php');
}

# load the rtl css file if needed
if (isset($_GET['rtl'])) {
    include('reboot-rtl.php');
}

?>

The way CSS works is that the rules that come first in the list on the page happen first, so anything that happens further down in the list can potentially overwrite the earlier rules. The thinking here is that if something else is controlling the font colour of the topic text, placing it at the very bottom will overwrite that..

Hope that helps!

Avatar
Alex T
Member
sp_UserOfflineSmall Offline
Feb 26, 2015 - 11:13 am

Thanks for that explanation.  I had tried it there as I figured that placing it at the very bottom was not correct since it had mobile codes there.  It still does not change the color though.  The thanks stat is still white.  

BTW...I have this in between the Member since date and the online status, in case that matters. This is what I have:

@media screen and (max-width: 379px) {
#spMainContainer #spLastVisitLabel {
display: none;
}
}

#spMainContainer .spTopicViewSection {
color: #000000;
}

<?php

# Load plugin file css (as .spcss files)
foreach (glob("*.spcss") as $f) {
include $f;
}

Avatar
Ike
Sawtry, UK
Member
Free Members
sp_UserOfflineSmall Offline
Feb 26, 2015 - 11:30 am

Where you have it is perfect, but..

I took a look at your forum and can see the problem - it's possible I've overlooked something. I put a fix in place for the colour but might have changed more than I thought - It's been a LONG week since I made the changes!

Try adding .spTopicPostSection to the rule, so:

#spMainContainer .spTopicViewSection,
#spMainContainer .spTopicPostSection {
    color: #000000;
}

Remove the CSS we did earlier and try this in the same place.

Avatar
Alex T
Member
sp_UserOfflineSmall Offline
Feb 26, 2015 - 11:33 am

That did it!  Thanks for all the help.  Hope this helps you fix things as well!  

Avatar
Ike
Sawtry, UK
Member
Free Members
sp_UserOfflineSmall Offline
Feb 26, 2015 - 11:44 am

Glad we got there in the end, and sorry - a couple of mistakes from me!

Yes it all helps. This one has already been fixed but keep them coming, I think we currently have 14 or 15 important fixes ready for the next update.

Avatar
Alex T
Member
sp_UserOfflineSmall Offline
Feb 26, 2015 - 12:04 pm

BTW...I just noticed that signatures started appearing, which was one of the things that wasn't working previously!  

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 649
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 616
Members: 17344
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10117
Posts: 79600