Support Forum

Icon Sets – Default Settings

YS Yellow Swordfish
Yellow Swordfish
Member
Member since Nov 2008
16,437 posts
Jun 3, 2009 · 9:35 am · Edited

This has positives and negatives…

I have added a file to each Icon set named ICON_DEFAULTS. When you change your current icon set, this will look for this file, and if found, set the icon text on/off dependent upon the set being used. So – for example – for the 'default' set, ALL icon text is turned on. For textural icon sets most text is turned off except those next to checkboxes in forms.

The positives are that new users wont have to perform the task and we wont have t keep explianing how this works.

The negative is that when we add a new icon and text we will have to update all of the documents.

ALSO NOTE: I have also now changed the showicon list to a serialized array instead of my own, old, odd mix of '@' and ';' delimiters. Makes it easier to add and remove. While in the code I also removed a couple that are now redundant.

4 Answers

New Answer
MP Mr Papa
Mr Papa
Member
Member since Dec 2006
19,448 posts
Jun 3, 2009 · 11:52 am

definitely like the second part… and well, the first…  though I wonder if it could be extended or perhaps something else for us to do on upgrade…

whenever we add a new icon, we invariable have to go update the styles/icons page to remove the label since we tend to use the 'word' icons…  sounds like updating that file wont help here since we dont change icons…  should we also update our upgrade process to include changing the display option for new icons to match whatever we set the default in the file to be?

YS Yellow Swordfish
Yellow Swordfish
Member
Member since Nov 2008
16,437 posts
Jun 3, 2009 · 12:23 pm

You've kind of lost me here…

“though I wonder if it could be extended”…. extended how or into what?

“sounds like updating that file wont help here since we dont change icons” ? Sorry – I don't know what you mean…?

“should we also update our upgrade process to include changing the display option for new icons to match whatever we set the default in the file to be?” This I DO get. This is already the case. The icon set used for a new install is 'default' and for that, all the icons are turned on as they should be.

MP Mr Papa
Mr Papa
Member
Member since Dec 2006
19,448 posts
Jun 3, 2009 · 12:28 pm

you said:

When you change your current icon set, this will look for this file

I was making the point that if we add new icons, the label text will always be 'on' even if we update this file to a default state of 'off' because the new file is not parsed (nor should it be because the user may have changed options)….

I was making the case that we should also in our upgrade script go through and set the actual user defined option for new icons in their currently select set to match what we set in that file…  currently, we dont touch the options thus the new text labels defaulting to 'on'….