Support Forum

Please review new mobile functions: sp_BreadCrumbsMobile(), sp_MobileMenuStart(), sp_MobileMenuEnd(), sp_MobileMenuSearch(), sp_QuickLinksTopicMobile, and sp_MarkReadMobile().

KW Ken Wilson
Ken Wilson
Member

Please review the 6 new Codex pages listed below. Whomever reviews a page, please indicate it is ready to publish or list the additional work required to make it ready to publish.  If there is too much detail or if the detail is too specific for all the mobile devices, please provide input.

sp_BreadCrumbsMobile()
0. Ready to publish after review.
1. New page developed and needs complete review.
2. Example came from spHead.php for Unified theme.
3. Changelog to 3/24/14 standard.

sp_MobileMenuStart()
0. Ready to publish after review.
1. New page developed and needs complete review.
2. $a = apply_filters(‘sph_MobileMenu_args’, $a); Should it be ‘sph_MobileMenuStart_args’ for consistency? If so, both CODE and CODEX need modification.
3. Example came from spHead.php for Unified theme.
4. Changelog to 3/24/14 standard.

sp_MobileMenuEnd()
0. Ready to publish after review.
1. New page developed and needs complete review.
2. There is no $a = apply_filters(‘sph_MobileMenuXxx_args’, $a) after the $a = wp_parse_args($args, $defs); Should there be?
3. Example came from spHead.php for Unified theme.
4. Please review Actions and Hooks especially the apply_filters(‘sph_MobileMenuEnd_after’, $out) explanation.
5. Changelog to 3/24/14 standard.

sp_MobileMenuSearch()
0. Ready to publish after review.
1. New page developed and needs complete review.
2. Example came from spHead.php for Unified theme.
3. Changelog to 3/24/14 standard.

sp_QuickLinksTopicMobile
0. Ready to publish after review.
1. New page developed and needs complete review.
2. Example came from spHead.php for Unified theme.
3. Changelog to 3/24/14 standard.

sp_MarkReadMobile()
0. Ready to publish after review.
1. New page developed and needs complete review.
2. Example came from spHead.php for Unified theme.
3. Changelog to 3/24/14 standard.

5 Answers

New Answer

SU SPF test User
SPF test User
Member

general note… 5.4.2 was released this weekend, so if not running out of trunk yet in svn, should get the latest and be using it as your guide vice the 5.4.1 listed in these tags…

general note..  did you create these pages yourself?  If so, need to be sure to mark the page as protected content…  and then only visible to silver, associate, gold, vip and staff…  these pages are for members only, so they have to be protected…

1 – published… minor wording tweaks… added in new class for current breadcrumb that has been added in 5.5.1… figured better early than missing… 🙂  (really will need to add it to standard breadcrumbs tag too)

2 – published with minor word tweaks…

3 – published with minor word tweaks…

4 – published with minor word tweaks…

5 – published with minor word tweaks…

6 – published with minor word tweaks…

KW Ken Wilson
Ken Wilson
Member

Understand about protections.  Also believe the published pages should be marked as “complete” instead of “needs writing” so this was also accomplished.  On the 7 new functions, the pages were protected and marked as complete as follows:

Protection done, marked as complete & updated by Klasen:
sp_MobileMenuEnd()

Protection done by Klasen, marked as complete  & updated by Wilson:
sp_MarkReadMobile()
sp_QuickLinksTopicMobile ()
sp_MobileMenuStart ()
sp_MobileMenuSearch()

Protection done, marked as complete & updated by Wilson:
sp_BreadCrumbsMobile()
sp_InsertLineBreak()

FYI: I believe I have 2 more functions to do:

sp_DeviceStats() – need to generate a Codex page.

sp_SearchForm() – need to update existing Codex page.

MP Mr Papa
Mr Papa
Member

yes, good point on the status…

just another bit on the protection…  not all pages on the site are protected… any of the detailed api type stuff will be…

MP Mr Papa
Mr Papa
Member

yikes… wrong…  5.5 was released this weekend (5.4.2 was months ago)…

another reason to get your svn set up… ;)