Yellow Swordfish said
Yes – keep it checked.
So what about the WP theme? Is there an option within that to control where the scripts are loaded – header or footer? You need to either remove the Bootstrap library or, in some way, ensure that it is loaded earlier in the page loading sequence. That way we can undo the damage it does.
If this option exists, I don’t see it anywhere.
Some themes have it and some don’t. As it’s a theme issue, it might be best to ask the theme developer directly.
Ike said
Some themes have it and some don’t. As it’s a theme issue, it might be best to ask the theme developer directly.
I just reached out to the theme authors, and am eager to hear what Mr Papa has to say about this.
hmmm… lol, not sure why everyone is looking at me… 😉
afraid no immediate thoughts and not sure what @yellow-swordfish was referring to as we were discussing another fix for some js changes… not sure how we impacted anything here… will have to try to find out what is happening to begin with…
wish themes would properly load bootstrap since its known to conflict with jquery ui… since that latter is core wordpress, theme authors should really ensure its loaded in proper order, but alas…
Any chance we can get an ETA on a fix? My users, including myself cannot post pics on our forum until this is resolved. 🙁
dont know how to fix/workaround the WP theme yet…. so no ETA… working on the more critical issue with the cancel function call…
okay, think I may have a way around this themes and bootstrap breaking wp jquery ui… but need help testing…
a handful of small changes…
in file simple-press/sp-startup/sp-load-forum.php, find this line
add_action('wp_enqueue_scripts', 'sp_load_forum_scripts', 1);
and add this line right after it:
add_action('wp_enqueue_scripts', 'sp_load_forum_footer_scripts', 9999);
then in file simple-press/sp-startup/forum/sp-forum-framework.php, find these lines and remove them:
# load up forum front end javascript that must be in footer
$footer_dep = array('jquery');
if ($tooltips) $footer_dep = array_merge($footer_dep, array('jquery-ui-core', 'jquery-ui-widget', 'jquery-ui-tooltip'));
$script = (defined('SP_SCRIPTS_DEBUG') && SP_SCRIPTS_DEBUG) ? SFJSCRIPT.'sp-forum-footer-dev.js' : SFJSCRIPT.'sp-forum-footer.js';
wp_enqueue_script('spforumfooter', $script, $footer_dep, false, true);
# sp_platform_vars is not static so cannot be in combined js cache but can be localized
$platform = array(
'focus' => 'forum',
'mobile' => $spMobile,
'device' => $spDevice,
'tooltips' => $tooltips,
'mobiletheme' => (current_theme_supports('sp-theme-responsive')) ? 1 : 0,
'headpadding' => ($spMobile) ? 0 : sp_get_option('spheaderspace'),
'saveprocess' => 0,
'checkiframe' => $iframe,
'pageview' => $spVars['pageview'],
'editor' => $spGlobals['editor'],
'waitimage' => sp_paint_file_icon(SPFIMAGES, 'sp_Wait.png'),
'successimage' => sp_paint_file_icon(SPFIMAGES, 'sp_Success.png'),
'failimage' => sp_paint_file_icon(SPFIMAGES, 'sp_Failure.png'),
'customizertest' => isset($_GET['sp-customizer-test']),
'autoupdate' => $sfauto['sfautoupdate'],
'autoupdatelist' => $arg,
'autoupdatetime' => $timer
);
$platform = apply_filters('sph_platform_vars', $platform);
wp_localize_script('spforumfooter', 'sp_platform_vars', $platform);
now, in same file, scroll down a bit to the end of this routine and find this code:
do_action('sph_scripts_end', $footer);
}
function sp_load_plugin_styles($ahahCall = false) {
and then change it to:
do_action('sph_scripts_end', $footer, $tooltips);
}
function sp_load_forum_footer_scripts() {
$tooltips = (defined('SP_TOOLTIPS') && SP_TOOLTIPS == false) ? 0 : 1;
do_action('sph_scripts_footer_start', $tooltips);
# load up forum front end javascript that must be in footer
$footer_dep = array('jquery');
if ($tooltips) $footer_dep = array_merge($footer_dep, array('jquery-ui-core', 'jquery-ui-widget', 'jquery-ui-tooltip'));
$script = (defined('SP_SCRIPTS_DEBUG') && SP_SCRIPTS_DEBUG) ? SFJSCRIPT.'sp-forum-footer-dev.js' : SFJSCRIPT.'sp-forum-footer.js';
wp_enqueue_script('spforumfooter', $script, $footer_dep, false, true);
# sp_platform_vars is not static so cannot be in combined js cache but can be localized
$platform = array(
'focus' => 'forum',
'mobile' => $spMobile,
'device' => $spDevice,
'tooltips' => $tooltips,
'mobiletheme' => (current_theme_supports('sp-theme-responsive')) ? 1 : 0,
'headpadding' => ($spMobile) ? 0 : sp_get_option('spheaderspace'),
'saveprocess' => 0,
'checkiframe' => $iframe,
'pageview' => $spVars['pageview'],
'editor' => $spGlobals['editor'],
'waitimage' => sp_paint_file_icon(SPFIMAGES, 'sp_Wait.png'),
'successimage' => sp_paint_file_icon(SPFIMAGES, 'sp_Success.png'),
'failimage' => sp_paint_file_icon(SPFIMAGES, 'sp_Failure.png'),
'customizertest' => isset($_GET['sp-customizer-test']),
'autoupdate' => $sfauto['sfautoupdate'],
'autoupdatelist' => $arg,
'autoupdatetime' => $timer
);
$platform = apply_filters('sph_platform_vars', $platform);
wp_localize_script('spforumfooter', 'sp_platform_vars', $platform);
do_action('sph_scripts_footer_end', $tooltips);
}
function sp_load_plugin_styles($ahahCall = false) {
we are inserting a new routine here after the first one…. save both files, clear your combined js caches and your browser caches, and give it a whirl…
would appreciate some feedback, please….
I made these changes, cleared combined forum css and js cache, then cleared browser cache and still, the same problem occurs. The “Start Upload” option does nothing.
Should I leave these php changes?
I have verified it corrects the problem… I would ask if the changes were made properly… did you copy the raw code popup and not from the post? otherwise, you may have gotten invalid characters…
all caches cleared as requested?
is your site viewable?
I stripped code of meta data via a plain text file before adding it to the PHP docs. It would be my understanding that I did everything exactly right. I sent you and the other two forum admins a PM.
meta data???? not sure there would be any in there…
I am unsure how this discussion got around to bootstrap… I dont believe it has anything to do with bootstrap… think its simply that you have jquery errors on your site… you alluded to them in post 9… but dont think they have anything to do with bootstrap… in fact, the code change you made would have resolved that… but those jquery errors are stopping things from working…
namely: Error: cannot call methods on button prior to initialization; attempted to call method ‘enable’
but believe this is going to be related to the wp 4.5 change and not simple press… wp jumped the jquery version multiple versions in this release… did you update your wp theme and other wp plugins? its possible one is still out of date or needs an update to be compatible with wp 4.5…
do you still have this problem if you temp switch to the default wp theme? if so, what about with all other wp plugins disabled?
I changed WP theme and that fixed this issue.
It turns out, many of the themes from those theme developers have this issue; I tried several from that company and all had the same issue.
Still having problems with the post Edit button, which we’ll continue to work out on the related support forum.
Question though – how can I delete images in my profile image upload directory after they’ve been uploaded?
This isn’t terribly important but we used to be able to do this on previous versions of SP.
When viewing your profile > attachments, you should be able to expand the tree (starting with date), select an image and use the ‘Remove Selected Image Attachment’ button.
Seeing as I was logged in to your site from the previous thread I double checked and it all seems to be working – Not that I’ve deleted anything!