Support Forum

Pop Up Windows Not Closing

SC scotchpotch
scotchpotch
Member

Hi

 

If the ‘view edit history’ or ‘policy policy’ are selected, or anything that shows a pop up window, the window cannot be closed unless you refresh the screen, there is no X on the top right of the box to enable it to close.

 

Forum link

9 Answers

New Answer

SC scotchpotch
scotchpotch
Member

Yes, I’m sure

 

Does not seem to work on my theme, did you try my forum link?

 

Did the pop ups on my forum close for you?

MP Mr Papa
Mr Papa
Member

yup. its there in the upper… 

however, in you sp theme, you removed the styles for the icons

.ui-dialog .ui-dialog-titlebar-close

should have an icon in there…

.ui-dialog .ui-dialog-titlebar-close {
    background-image: url(“images/close.gif”);
    height: 18px;
    margin: -10px 0 0;
    padding: 0;
    position: absolute;
    right: 12px;
    top: 14px;
    width: 18px;
}

did you lose that style?  or perhaps your theme is not providing them like our provided themes…

SC scotchpotch
scotchpotch
Member

hmmm, curious

 

Here’s my code…

 

.ui-dialog .ui-dialog-titlebar-close {
    position: absolute;
    right: 12px;
    top: 14px;
    width: 18px;
    margin: -10px 0 0 0;
    padding: 0;
    height: 18px;
    background-image: <?php echo($ImageClose); ?>

 

And you will notice that the image close is on the last line – I’ve never touched this code so I’m assuming that maybe the original default theme has been updated?

 

Anyway, copied your code onto my theme – and it works fine.

 

Thanks for your help on this one.

MP Mr Papa
Mr Papa
Member

is ImageClose defined in your overlay file? if not that would be the reason…

SC scotchpotch
scotchpotch
Member

Using your code, it all works fine though.

 

Nothing on the overlay for ImageClose

 

Your code: background-image: url(“images/close.gif”); at the top of the routine.

 

My code:  background-image: <?php echo($ImageClose); ?> at the bottom of the routine – PHP within PHP?

 

As I’ve said, it works fine now.

 

Off to bed now, 6.30am in the morning here.

 

Thanks again

MP Mr Papa
Mr Papa
Member

that was my point… the php echo says its getting the value of ImageClose from the overlay… so thats why no image if you did not define it in your overlay…

any php statements in your main css file (.php) need to have that variable defined somewhere or it will be blank…

SC scotchpotch
scotchpotch
Member

I’ve checked the overlay file.

 

I had adapted the berries-n-cream.php overlay, calling it HoneyGold.php and stored a copy locally in case it was overwritten, which indeed it was. When I upgraded to 5.0, I copied my new overlay over.

 

On checking the current copy of berries-n-cream.php, I notice it is completely different from my adapted version. So you are right when you advised that ImageClose was not defined on my overlay.

 

The berries-n-cream.php I had adapted was the 4.5 version. I’ll make a new version of my overlay using the up to date berries-n-cream.php

YS Yellow Swordfish
Yellow Swordfish
Member

Sounds like a ‘beta’ issue in that we do still need to make the odd change to files like overlays and themes prior to a full and final release. They are getting more and more stabilised however as we get nearer to this.