Support Forum

Trying to get property of non-object in Error log relating to Smileys

KE Kenn
Kenn
Member
Member since May 2012
171 posts
Dec 12, 2013 · 9:38 am · Edited

My error log is full of  

file: /simple-press/forum/content/forms/sp-form-components.php
line: 469
function: sp_post_editor_smileys_options
Notice | Trying to get property of non-object

 

Could you offer any advice as to why this might be there as all smileys seem to be working fine when in a post but I’ve noticed when a post is quoted in the next post, instead of the smiley in the quote it says:

title=”Laugh” alt=”Laugh” src=”http://www.sitename.co.uk/wp-content/blogs.dir/1/files/forum-smileys/sf-laugh.gif” />

 

Line 469 of sp-form-components.php is:

if (sp_get_auth(‘can_use_smileys’, $spThisForum->forum_id)) $display[‘smileys’] = true;

Thanks for any help.

6 Answers

New Answer
YS Yellow Swordfish
Yellow Swordfish
Member
Member since Nov 2008
16,437 posts
Dec 12, 2013 · 12:46 pm

The notice is pretty unimportant – just a nuisance. Can I ask that you clear the error log and then also go to the forum admin > Toolbox > Housekeeping and run the task to reset the user authorisations. See if that stops the notice message appearing…

I didn’t know about the quoted smileys. Haven’t seen that or had it reported before. I will open a bug report on that straight away to make sure we get it fixed. Thanks for the info.

KE Kenn
Kenn
Member
Member since May 2012
171 posts
Dec 12, 2013 · 1:22 pm

Thanks for the reply, done a suggested and by the time I’ve refreshed the page there are 6 entries in the error log.

YS Yellow Swordfish
Yellow Swordfish
Member
Member since Nov 2008
16,437 posts
Dec 12, 2013 · 3:10 pm

6? What version are you using please?

KE Kenn
Kenn
Member
Member since May 2012
171 posts
Dec 12, 2013 · 3:55 pm

Hi,

I am a couple of versions behind, we tried to update a week ago and had to resort to restoring a backup because it wouldn’t update correctly. We have several custom made plugins and they require so much testing before an update to check nothing breaks that we have fallen behind. We are running SP5.3.1 on WP3.6

Apologies if this has been resolved in your update, I should have thought of that first.

YS Yellow Swordfish
Yellow Swordfish
Member
Member since Nov 2008
16,437 posts
Dec 12, 2013 · 4:02 pm

Well I can not really confirm if that is the case. We DO clean these up whenever we can and we or a user reports them. Mostly – as i say – they are just nuisance value. I asked about the version more because the error log has changed and we no longer create duplicate entries for a notice but consolidate all the instances into one entry.

The permission to enable users to use smileys was added a few versions back and should have initialised itself upon upgrade. Clearly in your case it did not and I was rather hoping the auths reset would perform the same task. You may need to go through the permission sets and re-save each one for this to take effect,

YS Yellow Swordfish
Yellow Swordfish
Member
Member since Nov 2008
16,437 posts
Dec 14, 2013 · 5:02 am

We are unable here to replicate the problem you mentioned with a smiley in a quoted post. Can you give us any further information? Like which editor for example. Is this every time you try it?

It is just possible that this is because of the older version you are using – there were one or two changes made to quoting an update or two ago. But I was not aware that this was a problem then either.