Support Forum

Theme selection question

KV kvr28
kvr28
Member

Wasn’t sure if this should go in theme or plugin forum, but I use a custom overlay through child theme based off the minimal overlay, I also have a custom dark overlay based off midnight as well and all default overlays in my child theme. I use the theme/language selection plugin so people can choose whatever overlay they would like to use. I notice since I have the minimal based custom overlay as default that the lightpack icons show no matter what theme you choose through the theme selection. Is this the way it is suppose to work?

12 Answers

New Answer

MP Mr Papa
Mr Papa
Member

ya know, Andy and I wondered out loud earlier this week if this Theme and Language Selection plugin would work with child themes – namely reboot…  put it on our list to verify…

seems you may have accelerated that…  so cannot answer you question definitively yet… well, it should work in standard way, but research needed…

KV kvr28
kvr28
Member

I actually just checked with the main reboot theme and seeing the same thing as well with that, thanks for looking into it, it’s not that big of a deal for pc because it has the text as well as icon, but for mobile it is a bigger issue, I can’t even see the upload icon switching to midnight since I had to use the one from here for my default theme, below is using child theme

this is what it looks like with minimal set as the default theme through main reboot and switched to midnight through the theme selector

MP Mr Papa
Mr Papa
Member

our concern, in the discussion, was with how we had to implement child overlays…  and if an issue, would affect a theme like reboot…

if I get chance tonight, will look into… for sure this weekend, we will take a gander…

MP Mr Papa
Mr Papa
Member

so think I have this selection plugin updated to work with child overlays and icon packs…

we need to do some more testing, but can hopefully get an update out this weekend…

KV kvr28
kvr28
Member

Works good from what I can see, icons switch perfectly on pc and mobile, the upload icon stays the same on mobile still though.

I even deleted the image file from the mobile folder that I had downloaded from here the other day thinking it might be over-riding, but it just goes back to the lighter color for both

thanks for the great turn around on this

KV kvr28
kvr28
Member

there is no sp_PlupAttachmentEditor.png in neither of the darpack or lightpack directories for reboot, the only place I could find it was in the upload plugin directory, which is a really light version, I had made a thread on it the other day

https://simple-press.com/support-forum/sp5-theme-topics/darker-version-of-upload-icon-for-mobile/

I think I figured it out though, I noticed there is no mobile directory under the darkpack folder either, so I created that directory, moved the lighter version of the icon into that and moved the darker version of the icon you folks use here into the lightpack mobile directory, it seems to be working.

KV kvr28
kvr28
Member

just tested on my live server and it is in fact working, thanks MP

MP Mr Papa
Mr Papa
Member

good to hear!  thanks for confirmation… will try to get a formal release out today…

when you see it, you might want to grab it too in case any final minute tweaks…  you wont see an update since version likely to be the same as one you have..