that is probably a good put and we can clarify that a bit…

SPQC said

Was giving a go at http://codex.simple-press.com/codex/themes/theme-basics/creating-a-theme/ and found an error. 

Good catch. I added more info to that section and included the php file name change.

Thanks for the heads up.

The screenshot show 1.0.10!  Must be coming with next update…  🙂  Where is the changelog? 

Also I want to report a little something now that I created my theme folder.  Whenever I switch back & forth between Default theme and mine, with the Activate button, there is a message that shows up at the top which is :

Fatal error: Cannot redeclare spdefault_textdomain() (previously declared in /wp/wp-content/sp-resources/forum-themes/SPQC/templates/spFunctions.php:17) in /wp/wp-content/sp-resources/forum-themes/default/templates/spFunctions.php on line 18

This don’t seem to have any impact but I’m telling you, just in case you know what’s going on.  Note that if I click Update Overlay, the message don’t show up.

yes, since 1.0.9 of the themes was updated, any new version will be 1.0.10…  and we do have a few minor mods – mostly cleanup…

please note, that codex page walked you through changing the spFunctions.php file so you wont get that error… you need to make changes in there…

spDefault is the textdomain for our default theme… you need to make your own for your own theme…

right before ‘try your new theme’… that step about editing spFunctions.php

That did it…  the 1st time I actually did it, then realized that I lost the translations so I reverted back to original and forgot.  oops!

So I did it like stated, which gives :

add_action(‘init’, ‘spSPQC_textdomain’);

# load the theme textdomain for tranlations
function spSPQC_textdomain() {
    sp_theme_localisation(‘spSPQC’);
}

What’s wrong?

so what’s the problem? still getting the error?

If I use the code above, no, no errors but translation is broken.  That’s why I reverted back and was having the rrror message but at least the translations were there.

well, if you create your own theme, you have to have your own translations… the translation for our default theme, uses the spDefault textdomain…

when you change spDefault to spSPQC, you have created your own textdomain for localizations, so you cannot use the translations from the sp default theme…

But renaming the .mo file as well should still work assuming the text strings have remained the same

Ok, I renamed it and it works.  That part was missing in the instructions, maybe add a little note about it?

the problem with telling folks to rename it would be if you changed some strings… say you wanted to reword some of the strings… renaming the file would not work since changing strings would have changed…

we might could add a note if no strings were modified you could reuse our translations… but hard to make clear the interactions…