Support Forum

Multiple Share This Buttons in Group View

JI jim
jim
Member

First off, nice work with Reboot!

I hope to use the new theme in our site overhaul, and it’s taking shape nicely. Just one concern I notice so far…

Share This buttons display under each Group.

All the shares from this view point back to the same page, the Forums home page. So why repeat the template tag under every group? It seems the Share This tag should appear once, above all the Groups, like it does in Forum view, above all the topics.

Our dev site is currently hidden, so I’ve attached a screenshot. I know I could hack the template, but my goal is to not create a custom theme to avoid edits upon updates.

Thanks in advance for any feedback!

Group View

sharethises.png

 

Topic View:

topicview.png

24 Answers

New Answer

YS Yellow Swordfish
Yellow Swordfish
Member

Yes – it was an error that slipped through. We missed it on the public support site and I have the ‘share this’ plugin turned off on my local development site because of the overhead and performance hit of it having to poll an external server.

We have the ticket open and it will be fixed up in the next day or so. We hope to issue a fairly quick Reboot update for the few bits and pieces that have cropped up since release and this is one of them!

Thanks Jim.

JI jim
jim
Member

I figured you guys would be on top of this!

Thanks again for all the great work.

YS Yellow Swordfish
Yellow Swordfish
Member

Teething problems. Always those simple things that get missed!

JI jim
jim
Member

Yellow Swordfish said
We have the ticket open and it will be fixed up in the next day or so. We hope to issue a fairly quick Reboot update…

Any chance this update is coming soon? Looks like the version available for download is still v1.0.

Or, could someone please provide a temporary fix for removing the duplicate Share This tags in Group view? We’re getting close to relaunching the new site, and I’m a bit lost since it appears the tag already appears only once, outside the forum loop…thanks!

spGgroupViewDesktop.php:43-52

                    sp_SectionEnd('', 'header');

                    sp_InsertBreak('spacer=0px');
                    sp_InsertBreak('direction=right');
                    if (function_exists('sp_ShareThisTag')) sp_ShareThisTag('tagClass=ShareThisTag spCenter');
                    sp_InsertBreak('spacer=5px');

                    sp_SectionStart('tagClass=spGroupForumContainer', 'forumlist');

                        # Start the Forum Loop
IK Ike
Ike
Member

Hey Jim,

Sorry for the delay with the update – Here is the fix copied from our changelog:

*Remove entire sp_ShareThisTag line from spGroupViewSection

*Move to first line inside sp_SectionStart(‘tagClass=spListSection’, ‘groupView’); before forum loop with sp_InsertBreak(‘spacer=5px’);underneath.

This should then appear something like:

# Start the 'groupView' section
        # ----------------------------------------------------------------------
        sp_SectionStart('tagClass=spListSection', 'groupView');
            if (function_exists('sp_ShareThisTag')) sp_ShareThisTag('tagClass=ShareThisTag spCenter');
            sp_InsertBreak('spacer=5px'); 
            # Start the Group Loop
            # ----------------------------------------------------------------------

Now you could float the share this button to the right by changing the ‘spCenter’ argument to ‘spRight’, and you could also change the sp_InsertBreak spacer to a lower or higher px value if you wish, or you could remove the sp_InsertBreak altogether if you don’t want too much of a gap, the clear that sp_InsertBreak adds is not necessary, it’s simply used to add a bit of a gap between the button and the top of the forums.

Still unsure of whether the release will be this weekend currently! Nothing set in stone.

Hope that helps.

MP Mr Papa
Mr Papa
Member

think we have decided to push the release to next weekend…  a few changes only a couple days ago and we need more testing time…  plus, its a UK holiday today where Andy and Ike are…

JI jim
jim
Member

Thanks for the update! But FYI…

It looks like Reboot v.1.0.1 is still showing duplicate Share This buttons in Group view.

They no longer show atop every group, but still do display twice.

I’m working on creating my Child theme now, but first I activated the latest Reboot update and fresh out of the box I got this…

sharetises.png

Cleared cache, de/reactivated Share this, and have updated to SP v.5.5.5…

I should be able to figure out removing the second tag in my sf-group view template, but thought you should know, and any tips are always appreciated.

JI jim
jim
Member

Looks like spHead template already calls the ShareThis tag in the Breadrumbs section…which is good for all other views, so it just really shouldn’t be in spGroup at all.

    # Start the 'breadCrumbs' section
    # ----------------------------------------------------------------------
    sp_SectionStart('tagClass=spCrumbHolder spLeft', 'breadCrumbs');

        sp_BreadCrumbs('tagClass=spLeft spBreadCrumbs&tree=0&icon=&homeIcon=sp_CrumbsHome.png&truncate=35', __sp('Home'));

        if (function_exists('sp_ShareThisTag')) {
            switch ($spVars['pageview']) {
                case 'group':
                    sp_ShareThisTag('tagClass=ShareThisTag spRight');
                break;
                case 'forum':
                    sp_ShareThisForumTag('tagClass=spRight ShareThisForum');
                break;
                case 'topic':
                    sp_ShareThisTopicTag('tagClass=ShareThisTopic spRight');
                break;
            }
        }

    sp_SectionEnd('', 'breadCrumbs');
JI jim
jim
Member

PS: This is the Desktop template. Mobile spHead file does not seem to have any ShareThis tag.

IK Ike
Ike
Member

Hey Jim,

This is a bit strange and not quite sure how the forum here doesn’t have the same problem. I’ll take a look at it in the morning as it’s getting pretty late here (or early!).

You should just be able to remove line 25 in the spGroupView.php template.

JI jim
jim
Member

Thanks Ike, got my child theme all set up and removed the ShareThis tag from Group view, keeping it in spHead, to show in other views.

A bit off track… but I might suggest one edit to the Child Theme instructions to clarify that the “root” template files (the ones that call Mobile or Desktop templates) must also be moved to the child’s /templates folder.

Instructions say to only include modified files. I couldn’t figure out why my child templates weren’t loading until I copied the unchanged parent template files to /child/templates and the modified templates to /child/templates/desktop (or /mobile).

Otherwise, very clear and thorough write-up. Thanks for all the effort!

MP Mr Papa
Mr Papa
Member

we have only realized that in the last day or so ourselves…  reboot was the first theme to break up the desktop and mobile like that…  so your suggestion only applies to reboot currently, but we will come up with way to address…

JI jim
jim
Member

OK, a couple things here I’ve noticed since updating to Reboot 1.0.1…

I’m trying to keep my child theme with as few edits as possible, so I wonder if these issues might be addressed in the next parent release.

1. I temporarily disabled my child Group View and notice there are still multiple Share This buttons. One for every group. The links shared all go to the same page. Only one is necessary atop all the groups, or perhaps it belongs back in the Head….

sharethises2.png

 

2. I have no modified Topic View template in my child theme for any device. There are two Share This buttons at the top of the topic, above all posts. The shared links generated are different, but they both direct to the same topic page…

sharethises-mobile.jpg

 

3. In the screenshot above, I also point out the floating Share This button that appears at the bottom of the mobile screen. We have a #top button that tends to cover it up and cause problems with a user clicking one or the other. Yes, I know I can move my button up but that would cause clutter and I just believe that floating button is redundant when share links appear above the forums.

First question: Any way to disable that floating button? I saw no option in the plugin options. Does it have its own template tag/call?

4. Forum View appears to be fine, with one share button atop all the topics. Except that is too has the redundant floating button, which I understand some people may prefer…

5. While editing files to modify my child theme, I noticed a consistent problem with many Reboot theme files. It may not be causing any issues, but I just downloaded a freash copy and confirmed that all /mobile and most /desktop templates reference the Unified theme, not Reboot. For example…

#   Simple:Press Template
#    Theme        :    Unified
#    Template    :    foot
#    Author        :    Simple:Press

All the files in the root theme direcory seem to have the correct theme name, but I did notice that all the PM templates do not reference any theme, if they are supposed to.

NOTE: Hopefully the next Reboot update will also correct the capitalization of the /Reboot directory name so child framework themes don’t break when it is updated. They call the Parent: Reboot (not: reboot)

Sorry for all this, but I hope I’m being clear and I hope it helps. Thanks!