Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
themes-topic
"Post Edited" Text?
Avatar
Lee H
Coastal New England (USA)
Member
Free Members
sp_UserOfflineSmall Offline
Jul 22, 2011 - 4:55 pm

Not sure this is a theme thing, but since I'd like to see it's output while theming...

Has the "Post edited 9:19 am – Jul 22, 2011 by Membername Here" text within the topic content been removed? Or not yet implemented? I can't seem to find any reference to it in the code. Nor does it show in the default template.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jul 22, 2011 - 8:03 pm

good question.  not sure I know the answer off hand...  will have to do some research...  ticket opened to make sure we dont lose it...

Avatar
Lee H
Coastal New England (USA)
Member
Free Members
sp_UserOfflineSmall Offline
Jul 22, 2011 - 8:56 pm

Thanks Mr. Papa

I'm sure theme authors could come up with a solution as grabbing the (now renamed) post_edit stuff isn't a big deal. Just wanted to make sure we weren't re-inventing the wheel as it seems you guys have thought of just about everything.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jul 23, 2011 - 5:30 am

Lee - it is one of those things that had a very divided response from users. Some loved it. Many hated it. In the default theme and topic view functions it is the function sp_PostIndexEditHistory() and by default is behind the button in the post area icons at top of each post and only appears if there IS history.

I thought this might be the best way to satisfy both camps!

If you want it displayed - as it is in previous versions - then the 'get' option can be used of course. But - I did just notice in the code that Steve has put the 'get' in the wrong place (too early) so I will correct that using the ticket he opened.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jul 23, 2011 - 5:54 am

Take that back. Steve has not put the 'get' in the wrong place. It's me that is wrong. I should have included an argument to use the popup or not. So that is what I will correct!

andy-signature.png
YELLOW
SWORDFISH
Avatar
Lee H
Coastal New England (USA)
Member
Free Members
sp_UserOfflineSmall Offline
Jul 23, 2011 - 10:33 am

As you said, the button should satisfy both camps. I did stumble acrossed the button/popup code later last night by tracking things backwards from the database table. But I assumed it was something visible from admin or profile view and I hadn't enabled it.

When making test edits on posts I "thought" I saw something shift, but didn't notice the new pencil buttons... even though I had been working with the button group. *headsmack*

I'm one that happens to like the text output, but with a small font and just the last edit. It can take up quite a bit of real estate if displayed like it is in this forum. Here's what we came up with for our SP4xx template, we kinda like it.

Image Enlarger

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jul 23, 2011 - 11:26 am

thats a 4.4.x skin???  bunch of core mods, eh?  or is that the 5.0 theme you are working?

Avatar
Lee H
Coastal New England (USA)
Member
Free Members
sp_UserOfflineSmall Offline
Jul 23, 2011 - 11:42 am

It's a 4xx skin. But I am starting to port to v5.

Nope, not one core mod, all pluggable and filters. The other views are more shocking. All in all it equaled one big effffing pluggable.php

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jul 23, 2011 - 12:28 pm

Wow. If you are planning to replicate this theme for V5 are you willing to share it? [Image Can Not Be Found]

andy-signature.png
YELLOW
SWORDFISH
Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jul 23, 2011 - 12:46 pm

ah, yes... I consider pluggable the same thing as modifying core... 😉

but should be easier to do in 5.0...  and will look cool!

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17364
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625