Support Forum

Subscriptions plugin bug

JB Jonathan Blyer
Jonathan Blyer
Member

I’ve been working with the Subscriptions plugin and noticed there is a significant issue when a user unsubscribes from a forum.

On line 68 of sp-subscriptions-database.php in the function sp_subscriptions_remove_forum_supscription, both the $forumid and $userid are passed into the function. However the query that is run only passes the $forumid.

The result is that when a single user tries to unsubscribe, ALL users for that forum are unsubscribed.

this is fixed by changing line 68 to

SP()->activity->delete(‘type=’.SPACTIVITY_SUBSFORUM.”&item=$forumid&uid=$userid”);

This is possibly due to the fact that another function “sp_subscriptions_remove_forum_subscriptions” has this behavior intentionally and has a very similar name (note the ‘s’ at the end).

Is there any possibility of getting this fixed applied to the code base?

1 Answer

New Answer

SP Simple Press
Simple Press
Admin

Hi:

Nice catch.  We’ve applied your fix and pushed a new version to our repository and licensing server.  New version is 2.1.1. 

Thanks for reporting this!