Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
requests-topic
Comment count in posts is wrong
Avatar
SoWhat
Member
Free Members
sp_UserOfflineSmall Offline
Mar 13, 2010 - 12:43 am

it doesn't matter if post revisions are enabled or disabled.

If you set $blogcomments to TRUE, then first LINKED comment is counted as 2. All next comments are counted as one, so we always get comment count +1.

Maybe this is not the best solution, but atleast it works:

 

function sf_comments_number($no_comment="0 Comments", $one_comment="1 Comment", $many_comment="% Comments", $blogcomments=false)
{
    global $wp_query;

    sf_initialise_globals();

    $result = $no_comment;
    $total = 0;
    $postid = $wp_query->post->ID;
    $links = sf_blog_links_control('read', $postid);

    # If linked get the post count (-1 of course)
    if ($links && sf_can_view_forum($links->forum_id))
    {
        # link found for this post
        $total = (sf_get_posts_count_in_topic($links->topic_id) -1);
        if ($total >0) $total=$total-1;
    }

    # If to include standard blog comments add that number
    if($blogcomments)
    {
        $total = ($total + $wp_query->post->comment_count);
    }

    if($total > 0)
    {
        if($total == 1 ? $result=$one_comment : $result=str_replace('%', $total, $many_comment));
    }
    echo $result;

    return;
}

 

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Mar 13, 2010 - 7:30 pm

I don't follow your argument and most definitely do not agree that this happens. Not on any of my tests does it happen.
However, there IS (in 4.2) a problem with the count if a forum post is awaitng approval as it gets included when it should not. Mayvbe that s where your extra one s coming from.
This is fixed in 4.2.1

andy-signature.png
YELLOW
SWORDFISH
Avatar
SoWhat
Member
Free Members
sp_UserOfflineSmall Offline
Mar 14, 2010 - 1:22 am

no, comment approval is turned off. Also Akisment plugin is disabled.

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17362
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625