Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
requests-topic
URL shortening
Avatar
BSABantam
UK
Member
Free Members
Offline
May 13, 2018 - 10:03 am

Will URL shortening include https:// addresses in the soon to be released update?

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
Offline
May 13, 2018 - 6:47 pm

currently investigating if this is an issue or not... frankly, not sure we ever tried it... 😉

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
Offline
May 13, 2018 - 6:59 pm

so yeah, does look like there is an issue there... thanks for reporting it...  will get a ticket opened for it and look at resolution - suspect its an easy fix...  if so, we can post it back here for you to use now...

Avatar
BSABantam
UK
Member
Free Members
Offline
May 14, 2018 - 6:18 am

OK, thanks.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
Offline
May 14, 2018 - 11:32 pm

think we have identified the issue...  working in a couple of quick tests...  more in depth testing needed, but looks promising... 

its a one line fix, so if it holds together, we will post the change here before too long...

Avatar
Yellow Swordfish
Glinton, England
SP Master
Offline
May 15, 2018 - 2:56 am

Here is the code fix should you want to make it. The file in question is:

/wp-content/plugins/simple-press/sp-api/sp-api-filters.php

This is a big file ansd the function needed is about one-third of the way through it around line 588:

sp_format_links()

In that function is this line of code:

$chunked = (strlen($urlname) > $charcount && preg_match('#^(http://|ftp://|www\.)#is', $urlname)) ? substr_replace($urlname, '.....', ($charcount - 10), -10) : $urlname;

Comment that kine out - put a hash (#) in front of the code line - then add below it this replacement:

$chunked = (strlen($urlname) > $charcount && preg_match('#^(http://|https://|ftp://|www\.)#is', $urlname)) ? substr_replace($urlname, '.....', ($charcount - 10), -10) : $urlname;

That should sort the issue.

andy-signature.png
YELLOW
SWORDFISH
Avatar
BSABantam
UK
Member
Free Members
Offline
May 15, 2018 - 7:18 am

That did the trick, thanks.

Great response as always!

Avatar
Yellow Swordfish
Glinton, England
SP Master
Offline
May 15, 2018 - 8:29 am

Always welcome
And thanks for the confirmation.

andy-signature.png
YELLOW
SWORDFISH
Avatar
BSABantam
UK
Member
Free Members
Offline
Sep 17, 2018 - 10:35 am

Was this fix supposed to be included in the recent update, or only in the forthcoming major release?

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
Offline
Sep 17, 2018 - 11:29 am

Not until 6. 0 comes out... The one past week was a security fix... 

6.0 is essentially ready... Just have to find time everyone is around to release... Vacations and work travel getting in the way 😉 

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17362
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625