Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
general-topic
BUG: Forum 'From' name used in emails not sent by forum
Avatar
benallfree
Rookie
Free Members
sp_UserOfflineSmall Offline
Jan 5, 2012 - 7:50 pm

Hi Friends,

 

I tracked down another bug relating to the forum 'From' name and wp_mail_from_name filter.

 

PROBLEM:

From Name configured in forum appears on outgoing emails from WordPress even though emails were not sent by forum.

 

STEPS TO REPRODUCE:

1. Configure forum From Name as 'foo'

2. Register as a new user on the WP site

3. Observe that email originates from 'foo'

 

RECOMMENDED FIX:

Enable wp_mail_from_name action only during emails that originate from forum. For an implementation reference, see how the s2member plugin calls add_action('wp_mail_from_name') and remove_action() before and after sending its emails.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 5, 2012 - 9:17 pm

we will have to research this...  in 4.5.x, we explicitly limited it to forum emails as you suggest... so its possible we broke that in 5.0 so will look into...

Avatar
cntrlwiz
Columbia City, IN
Member
Free Members
sp_UserOfflineSmall Offline
Jan 7, 2012 - 9:44 am

Guys...I have this problem too.

I use a plugin called Newsletter Pro to send emails out to about 180 members of our group, and I noticed that the "From:" on those emails was 'forum', not 'newsletter' as I had set in the Newsletter Pro config.

I changed the forum "From Name" to 'wtf', and tested my newsletter...and its "From:" was now 'wtf'.

So, I have confirmed the above bug.  This was not an issue for me in 4.5.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 7, 2012 - 10:22 am

understood.. as said before ticket open to look into...

Avatar
Brandon
U.S.
SP Wrangler
Free Members
sp_UserOfflineSmall Offline
Jan 7, 2012 - 10:24 am

In help popup that is shown on the Options - Email Settings it says.

Note: These settings, once made, are global in that they will be used by WordPress for non-forum emails as well.

 

So it appears to be setup to work that way right now.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 7, 2012 - 10:29 am

just a really old help message.... its how it worked many years ago...  in 4.4.something we changed it to only be on emails from the forum...  it seems we lost that somewhere in the 5.0 work...

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 8, 2012 - 7:48 pm

this was corrected in the latest RC update push... build 7705...

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626