Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
general-topic
Clicking a forum name with a space in it formats wrong
Avatar
BlueDagger
Member
Free Members
sp_UserOfflineSmall Offline
Feb 19, 2012 - 10:27 pm

Looks like that is an error with clicking name links to profiles. Names with a space have the space dropped the when the link is clicked from the forums rather then a %20 being added to the URL. Our profiles are are forwarded to the buddypress profiles do not sure if it's an issue for just normal simple press profiles.

Lead site admin for RM40k.com

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Feb 19, 2012 - 10:29 pm

do you have link to example? cause clearly not an issue here (see me and/or yellow swordfish)...

but could be related to bp...

Avatar
BlueDagger
Member
Free Members
sp_UserOfflineSmall Offline
Feb 20, 2012 - 12:12 pm

Yeah, my assumption is it is purely related tot he passover from clicking on a member's name link in the forums and when it tries to generate a URL to point to buddypress. Here is some example pages for one of our users "Sardonic Artery".

 

Here is a forum topic with him included, so that you can see the link: http://www.rm40k.com/forums/wa.....ead/#p8056

 

Here is a link to a location you can see his link within Buddypress:

http://www.rm40k.com/members/

 

Here is the actual link to his profile page:

http://www.rm40k.com/members/S.....y/profile/

Lead site admin for RM40k.com

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Feb 20, 2012 - 7:56 pm

a bit confused here....  the link on your example has a space in it too (the bp members page)... so its not the space...

but the link on your site its a different name...  looking at some others, many are a different name...  so what is buddypress using the link?  is that the login name(wow, wouldnt like that)? or other?

Avatar
BlueDagger
Member
Free Members
sp_UserOfflineSmall Offline
Feb 20, 2012 - 9:23 pm

When you click on the person's name though you get two different URLS from the two systems...

 

If you click on Sardonic Artery's name from the BP Member page you get his page and clicking on profile you get:

h ttp://www.rm40k.com/members/sardonic%20artery/profile/

 

If you click on his name in the forums you get:

h ttp://www.rm40k.com/members/SardonicArtery/profile/

 

The forums link throws an error since there is no "SardonicArtery" but rather "Sardonic Artery" which the BP press side puts a %20 in the URL to signify.

 

Note: I put a space in the http to break it from hiding a part of the link.

Lead site admin for RM40k.com

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Feb 20, 2012 - 11:00 pm

something not right here...  the 'names' all look odd... same for your name... bluedagger, not BlueDagger...  and look at Rlumsden - that becomes malefactor...

so my question still stands... where is the actual value coming from???  which wp user db column is used to get to the profile????

and still a bit confused because we have quite a few folks that use buddypress and link to the profile and this oddity with names has not come up before...  are you perhaps running a buddypress plugin that has changed that? or is it optional?

we have always passed the wp user_login as the user argument to buddypress and its been working fine...

so again, either something has changed or you have a plugin or different option selected...  any ideas?

Avatar
BlueDagger
Member
Free Members
sp_UserOfflineSmall Offline
Feb 21, 2012 - 10:55 am

Thanks a bunch for sticking with this one, I figure its a bit low priority right now with the 5.0 release (which by the way kudos on!).

 

The only BP addon we have is BP_Humanity for a Q&A style spammer protection (which works flawlessly for anyone curious)

 

I know that some of our users have a different display name then their user login name if that is what you mean. Wordpress allows the user to pick what they want their name to be displayed as publicly. Malefactor, for example, has "malefactor" as his username he logs in with, but his name is displayed publicly as "Rlumsden". BP looks as though it uses the WP login name not the display name for this.

 

SP looks like it's smart enough to use the login name even if I turn my display name to "Rob Brock". My actual username is "BlueDagger" which both SP and BP pickup on the capitalization correctly. It's look though that if there is a space in the username it trips up SP.

 

---

 

While typing this up I did some testing and it looks like Wordpress doesn't allow a username creation with a space, so the username must have made it through that was by importing our users in from our old phpBB forums with the import tool.

 

Since that is the case I'll just try to sift through my users and cleanup the accounts on a case by case basis since spaces in our forum names are rare. However good to be aware that other importing will see the same issue.

Lead site admin for RM40k.com

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Feb 21, 2012 - 8:25 pm

actually WordPress does allow usernames with spaces... I create them all the time and mine has one...

but anyways, so maybe we have just missed the space...  can you find file sp-api-common-display.php and go on down to line 401 and find

            $site = SFSITEURL.'members/'.str_replace(' ', '', $user->user_login).'/profile/edit/';

and then try changing it to:

            $site = SFSITEURL.'members/'.str_replace(' ', '', urlencode($user->user_login)).'/profile/edit/';

and see if that fixes it up for you?

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17362
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625