Support Forum

Actually upon further testing I'm finding that the behavior is pre-filling the user information from the creator of the thread (not the latest thread reply; it was simply a coincidence in the first reported case that the latest thread reply had been from the thread creator).

This isn't the expected "remember" behavior, which should pre-fill only with the particular visitor's information. The reported bad behavior is of course an issue in that everyone can see the thread creators' e-mail addresses. This doesn't seem to be related to the cookie setting.

With more testing, it looks like it pre-fills with the last guest in the thread, which is sometimes the first post, sometimes the last post, and sometimes somewhere in between  And you won't see this behavior if you are a recurring guest, because you'll have cookie data.

It appears to be related to this code from forum/content/forms/sp-form-post.php (and possibly similar with the add topic form):

Specifically, if there is no value in the cookie, it defaults to the value in $spThisUser, which for the guest_name and guest_email values at least, have been set to a user in the thread.

I don't think it's the transient records or cookies. That appears to be working fine.

It has been reported by several users in the live environment, and isn't due to repeated posting of the same guest user trying to use different names and e-mail addresses (in other words, it's not just me pretending to post as multiple people for testing purposes).

If I replace this:

if (isset($f['guestemail']) ? $guestemailval = esc_attr(stripslashes($f['guestemail'])) : $guestemailval = $spThisUser->guest_email);

with this

if (isset($f['guestemail']) ? $guestemailval = esc_attr(stripslashes($f['guestemail'])) : $guestemailval = '');

Then the issue is solved (at least in a band-aid way) because we don't fall back to $spThisUser values.

This is possibly traced back to the in-memory caching in sp-api/sp-api-class-user.php, which populates $spThisUser several times in a page load:

function sp_get_user($userid=0, $current=false) {
 global $USERS;
 if(!array_key_exists($userid, $USERS)) {
 $USERS[$userid] = new spUser($userid, $current);
 }
 return $USERS[$userid];
}

If you have a guest post in a thread, it fills the $USERS global with ID 0, and I think that's how it ends up pre-populating the guest name and e-mail fields with someone else's information. (See also line 287 in forum/content/classes/sp-topic-view-class.php)

$t[$tidx]->posts[$pidx]->user                           = sp_get_user($r->user_id);

This only happens on posts since 5.x, because user_id in the wp_sfposts table now gets ID = 0 for guest posts while this used to be NULL.

Let me know if you want me to show a live example and I'll send you a PM with some instructions.  (I applied the band-aid patch on my live install to prevent people from abusing the e-mail address leaks.)