Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
general-topic
Share this plugin tweaking :)
Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 10, 2016 - 1:31 am

assume you mean uninstall the share this plugin... in this case, it wouldnt hurt, but doubt it will help either...

just confusing since we have no way of changing the button as shown in the current version...

would be interesting to actually look at the plugin code, but not easy... did you get the 1.1.9 version from the admin or looking at the file itself?

Avatar
critterGuide.ca
Canada
Member
sp_UserOfflineSmall Offline
Jan 10, 2016 - 8:22 pm

it is from the plugins list in Forum plugins > 1.1.9

 

deleted and downloaded from your website and stil the green icon.

Avatar
critterGuide.ca
Canada
Member
sp_UserOfflineSmall Offline
Jan 10, 2016 - 9:06 pm

so u commented some stuff out.

// if ($spDevice == 'mobile') { 
// $style = '_large'; 
// $text = ''; 
// $out.= "<span class='st_sharethis$style' $url $title $summary $text></span>"; 
// } else {

ALL THE ACTUAL SHARING BUTTONS DEFINITION HAPPENS HERE

 //           }  <<<< //Stas

 

not sure if that is the correct fix but i can see the buttons now....

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 10, 2016 - 9:15 pm

where are you seeing that? I cannot find it in our plugin...  or themes...

so not sure what you are looking at or what you are doing...

but as we have said, previous to the latest release we were forcing the sharethis widget in mobile, but removed that forcing in the latest plugin version...

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jan 11, 2016 - 3:12 am

These are, indeed, the very lines of code I removed for the last update.

andy-signature.png
YELLOW
SWORDFISH
Avatar
critterGuide.ca
Canada
Member
sp_UserOfflineSmall Offline
Jan 11, 2016 - 8:42 am

Well..you need to update your plugin guys as this is in this version..components..

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 11, 2016 - 9:10 pm

Need to get with @yellow-swordfish as I cannot find them in the version I downloaded from the store...  and we are on different sides of the world, so need him back in AM...

Avatar
critterGuide.ca
Canada
Member
sp_UserOfflineSmall Offline
Jan 14, 2016 - 3:50 pm

so wasthe last update was because of me :)?

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jan 14, 2016 - 4:37 pm

Yep - red faces time! But none of us know how this can happen. We use the standard SVN for source code control and that definitely shows those lines of code removed for that build yet you were absolutely right - they were in the downloadable file.
Not seen that before and hopefully will not see it again.

andy-signature.png
YELLOW
SWORDFISH
Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626