Support Forum
Support Forum
Offline
Version 2.0 of Chris Pearson's Thesis theme just came out and unfortunately Simple:Press is incompatible with it.
As Chris himself tells me, the incompatibility is due to how Simple:Press handles jQuery. He says it's an easy fix for the Simple:Press developers. He said S:P calls up a bad version of jQuery and unnecessarily loads jQuery even on pages without S:P (such as the Thesis admin pages), and this hoses admin pages. I know of at least one deal-killing conflict. There may be more I haven't encountered yet. With Simple:Press plugin activated, the Thesis admin menus do not work so it's impossible to change settings or otherwise modify your site through Thesis.
I'm hoping y'all can make the necessary changes soon. I'd hate to have to choose between upgrading to the newest (and awesome) version of my favorite them and keeping my Simple:Press forums. I love 'em both and want to keep using both.
Offline
Not a lot of informations to go on here including some that does not make any sense.
How does simple Press include 'a bad version of jQuery'??? The only version we ever load, if and when we load one, is the version that ships with WP. How does he consider that' bad'???
And we certainly try to only load it when needed. If he knows of somewhere this is happening when it's not needed we would certainly look into it. But if thesis chokes when the wp version of jQuery is loaded, that is something thesis would need to worry about and fix.
So more details please....
Visit Cruise Talk Central and Mr Papa's World
Offline
I'm not a programmer, so I don't know if I can be of much more help.
I can tell you that there is definitely a conflict. I've tested Thesis 2.0 and the current version of Simple:Press on my main site and on a new test site. The test site only has S:P, Akismet, and WordPress Importer plugins installed and activated. Simply activating the basic S:P plugin blocks the Thesis admin menus, before the full S:P plugin is even installed. After full installation of S:P, I tried every possible combination of integration and display settings under the Integration menu. Nothing resolved the conflict and unblocked the Thesis menus. Deactivating the S:P plugin instantly resolves the conflict, however.
Offline
Comparing page source of the main Thesis admin page with and without S:P activated (I can provide you with the full page source of both if needed), some differences I see are:
In the head:
<link rel='stylesheet' id='spMenuStyle-css' href='http://test.prometheus-unbound.org/wp-content/plugins/simple-press/admin/resources/css/spa-menu.css?ver=3.4.2' type='text/css' media='all' /> <script type='text/javascript' src='http://test.prometheus-unbound.org/wp-content/themes/thesis/lib/js/menu.js?ver=3.4.2'></script> <script type='text/javascript' src='http://test.prometheus-unbound.org/wp-includes/js/jquery/jquery.js?ver=1.7.2'></script> <script type='text/javascript' src='http://test.prometheus-unbound.org/wp-admin/js/utils.js?ver=3.4.2'></script>
The S:P stylesheet and jquery.js?ver=1.7.2 are loaded only when the S:P plugin is activated.
In/after the footer, this is without S:P activated:
<script type='text/javascript'>
/* <![CDATA[ */
var commonL10n = {"warnDelete":"You are about to permanently delete the selected items.n 'Cancel' to stop, 'OK' to delete."};/* ]]> */
</script>
<script type='text/javascript' src='http://test.prometheus-unbound.org/wp-admin/load-scripts.php?c=1&load=admin-bar,hoverIntent,common,jquery-color&ver=3.4.2'></script>
And this is with S:P activated:
<script type='text/javascript' src='http://test.prometheus-unbound.org/wp-includes/js/admin-bar.js?ver=3.4.2'></script>
<script type='text/javascript' src='http://test.prometheus-unbound.org/wp-includes/js/problem-with-post-edit-buttonoverIntent.js?ver=r6'></script>
<script type='text/javascript'>
/* <![CDATA[ */
var commonL10n = {"warnDelete":"You are about to permanently delete the selected items.n 'Cancel' to stop, 'OK' to delete."};
/* ]]> */
</script>
<script type='text/javascript' src='http://test.prometheus-unbound.org/wp-admin/js/common.js?ver=3.4.2'></script>
<script type='text/javascript' src='http://test.prometheus-unbound.org/wp-includes/js/jquery/jquery.color.js?ver=2.0-4561m'></script>
I hope this helps.
Offline
Sounded like someone gave you info and it sounded incorrect unless they consider the jQuery that ships with WP to be bad. So was hoping for more info along those lines and what research they did.
Is thesis free? That is, something we could download to research...
Visit Cruise Talk Central and Mr Papa's World
Offline
Mr Papa said
Sounded like someone gave you info and it sounded incorrect unless they consider the jQuery that ships with WP to be bad. So was hoping for more info along those lines and what research they did.
Not sure. You might contact Chris for more information. I guess the conflict came up in testing. He also recommended talking to @byobwebsite for more details.
Is thesis free? That is, something we could download to research...
Afraid not. I can't speak for Chris, but maybe he would be willing to let you look at the code for the purpose of resolving the conflict?
Offline
Sorry, Andy and I are both on road and can't see the code via email. So will be couple days before I can look at. Maybe Brandon can see take a look.
Hard to really research too with actually running thesis.
In your comparison, did you have any simple Press plugins active? Is so, might be interesting to see without any.
And stil troubled by thesis having issues with wp jQuery loaded. Mighty strange that it wouldn't like it. Hopefully it's not loading a non wp jQuery version.
But agree if it's sp loading jQuery and we are not on forum admin page, we should not be forcing it to load. Hence my question about no sp plugins. Wonder if a plugin us doing it. Will certainly research that.
Visit Cruise Talk Central and Mr Papa's World
Offline
Mr Papa said
In your comparison, did you have any simple Press plugins active? Is so, might be interesting to see without any.But agree if it's sp loading jQuery and we are not on forum admin page, we should not be forcing it to load. Hence my question about no sp plugins. Wonder if a plugin us doing it. Will certainly research that.
No S:P plugins installed or active in that comparison. It's just the core S:P plugin on the test site.
Offline
Okay, thanks. Will look into when back to computer later this week.
Visit Cruise Talk Central and Mr Papa's World
Offline
Hi
Mr Papa said
Okay, thanks. Will look into when back to computer later this week.
I fixed this issues
go to wp-content/plugins/simple-press/sp-config.php
find this line
define('CONCATENATE_SCRIPTS', false);and set to true like this
define('CONCATENATE_SCRIPTS', true);
All RSS1 Guest(s)