Support Forum
Support Forum
Offline
Weirder and weirder...
Would you be able to copy one of the SP code files, zip it up and post it here as an attachment so I can compare it because something is not tying up quite right.
If you can then the file to go for is /simple-press/sp-api/sp-api-filters/php...
 |
YELLOW
SWORDFISH
|
Offline
Please find here an archive of the whole simple-press plugin directory from the live site.
If you look at the file dates of the archived files, you will see 2 modified files:
- sp-api/sp-api-filters.php
I did make some changes yesterday as a test but I restored the original file. As I wasn't sure it would be 100% original, I downloaded the original SP package on your site and extracted that single file to its original location on my site. This is current file in place on my site, and the one you see in the archive
- forum/database/sp-db-statistics.php
There is a small change I apply on SP core after each update, to get moderators included in the top poster stats of the site.
I can also post the MD5 of all files if needed.
Thank you for your help.
Offline
The one you sent me here is correct but it is still NOT the same code that is creating that div on your site which was updated in either 5.7.2 or 5.7.3.
This is most disconcerting! And I am totally stumped. Let's bring my colleague into this to see if he has any ideas.
@mr-papa - If you look here - http://www.arctablet.com/blog/.....r-display/ - you will see that the reveal link does nothing. If you inspect the code you will see that the link uses the old style format (before the listener) but without the JavaScript call on the onclick. So no 'data' items get defined from the sp_filter_display_spoiler() display function.
I can not replicate this. And everything says the site is using 5.7.3 - and the code behind this IS 5.7.3.
I am out of ideas...
|
YELLOW
SWORDFISH
|
Offline
when you upgraded, did you use the updater? or ftp? basically, making sure you dont have two simple press folders (one with slight name change) in the plugins folder of WP...
Visit Cruise Talk Central and Mr Papa's World
Offline
Hello,
Updates have always been done thru Wordpress updater and I have just checked there is just one "simple-press" directory and no similar name in my wp-content/plugins directory.
I have changed line 1952 on file sp-api-filters.php, by changing $out = ''; to $out = '....';
And as you can see this link the change is properly applied on the page (you can see the 4 dots just before the spoiler link)
Which other parts of SP code are responsible to the spoiler link click and spoiler content display ?
I am not sure to clearly understand, I'd really need some help to know the history for the spoiler changes internally in SP and how they relate to my case. What could I manually change in the code to temporary fix the problem, at least until we get a better understanding of the situation ?
Thank you.
Offline
I think I might have stumbled on the problem here. Although why I too see your issue yet do not see it using the same code on this site is a conundrum. And then again - maybe I am wrong anyway about finding it. All we can do is ask you to try this. It will involve a small edit to the sp-api-filters.php file.
The function in that file is way down at about line 1940 and is called sp_filter_display_spoiler().
Find the line of code that starts:
$out.= "<a id='spRevealLink'$spoilerID'
You will see that there is an errant and stray apostrophe in there that should not be there. The oine before the $. It should be:
$out.= "<a id='spRevealLink$spoilerID'
Can you make that change and see if that corrects your issue.
|
YELLOW
SWORDFISH
|
Offline
It's working now, you're a star ! 
The changed line is 1957 not 1940 on my original sp-api-filters.php file (rev. 14726)
That problem originates from the original SP package I believe ? (my sp-api-filters.php was restored from the original SP as I mentioned yesterday).
Thanks again !
Offline
I don't even want to think about different line numbers!
The really odd thing is that it still worked - with that code - on this site here. So here we were still seeing the rest of the 'a' tag data settings that were visibly missing from your site. That's why these sort of situations can be so hard to pin down and spot solutions for,
That was made more difficult on your site as all the single quotes were being changed to doubles! Again - I have no idea why!
Anyway - the important thing is that it is fixed and working and sorry it took so long. It was one of those obvious things staring you in the face that you could not see!
|
YELLOW
SWORDFISH
|
Offline
I just gave the correct line numbers in case other forum users with latest SP build here want to easily apply the fix. Will this spoiler fix be pushed to next SP update ?
The difference between sites probably relates to PHP versions and PHP ini settings, which I admit can be troublesome. About my site changing single quotes to double, I'll check why but it's probably a PHP configuration topic as well.
Thanks again for your help, I feel my small financial contribution to the support forum makes more sense now 
Cheers.
Offline
sptab said
I just gave the correct line numbers in case other forum users with latest SP build here want to easily apply the fix. Will this spoiler fix be pushed to next SP update ?
But that's the odd thing. I believe the line number I quoted should be correct fore the current version although I was testing and working with 5.7.4 code so there may have been some small changes before this. But yes - the fix is already in the next update build - probably due any day actually.
The difference between sites probably relates to PHP versions and PHP ini settings, which I admit can be troublesome. About my site changing single quotes to double, I'll check why but it's probably a PHP configuration topic as well.
You are most probably right - I am far from being that cognisant with all the byways of the php.ini file 🙂
Thanks again for your help, I feel my small financial contribution to the support forum makes more sense now
Cheers.
Thank you - that is very much appreciated.
|
YELLOW
SWORDFISH
|
All RSS1 Guest(s)