Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
general-topic
Unable to edit profile in Unified theme used as Mobile Phone Theme
Avatar
Thorsten B
Member
sp_UserOfflineSmall Offline
Jul 1, 2015 - 8:44 am

I have some feedback form the theme developer o n this issue. Took a while for them to get around to check but here's what they found:

 

I found the reason why you got this issue but I don't know how to fix it 🙁

Problem is native jQuery UI script we used for UI elements in our theme (accordion, tabs etc) https://jqueryui.com/

And when I went into your stockholm theme folder/js/plugins.js and removed this code from screenshot

http://screencast.com/t/bNk4drfhEW

then your forum works fine, also I tried to upload the latest version of this script and problem is same.

So you need to contact author of this plugin and to see is there some solution for this when we know what is the problem now. Thanks

Any further ideas as they are obviously not sure what to do?

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jul 1, 2015 - 9:07 am

Well this is what we have had to say on this subject before:

https://simple-press.com/docum.....-conflict/

Theme and plugin authors MUST use the standard, supplied, tested and fully supported libraries that WordPress supplies for this very reason.  The WP team are considering banning themes and plugins from their repositories that do not adhere to this simple requirement.

Any plugin that utilises these core scripts - like Simple:Press - is in danger of being broken by this disregard for standards. I can think of no excuse for breaking them.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Thorsten B
Member
sp_UserOfflineSmall Offline
Jul 3, 2015 - 3:42 pm

Well that's good to know (I guess) though it doesn't really help me since I have no influence on the internal structure of products I purchase. I am just a customer that trust everyone knows what they're doing. However, I shared your feedback with the theme developers. I know close to nothing about jquery but by the googling I've done it appears they load UI elements from a bundled external library when actually all of this is included in WP since version 3.3 - at least that's how it looks from my simplistic perspective.

I am curious though as to why everything works just swell except for that tiny portion in the SP mobile template. Nothing else is affected, neither on the desktop side nor other parts of the mobile side. Just the profile section on just the mobile theme.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jul 3, 2015 - 11:11 pm

since its a non standard jquery library, hard to tell.. but might just be slightly different version than that package with wp, so not 'routinely' used...

is your theme doing anything with the ui elements on the forum page?  could it be selectively disabled on the forum page?

Avatar
Thorsten B
Member
sp_UserOfflineSmall Offline
Jul 4, 2015 - 2:17 pm

I don't think it's really doing anything with the ui elements on the forum page. I actually use none of the "fancy" features of this theme (animated titles, ajax loading, etc.). I was wondering too if it could be selectively disabled or perhaps block the jquery ui it loads for just the forum.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jul 4, 2015 - 7:23 pm

we are saying the same thing...

is this theme updates often?  would be pretty easy to modify it for this, but changes would be lost if the theme is updated...

if you can find where in the theme its loading its own version of jquery ui, we might be able to offer some code to override it for forum pages...

Avatar
Thorsten B
Member
sp_UserOfflineSmall Offline
Jul 7, 2015 - 2:28 am

The theme developers came back to me and went above and beyond to change their theme (which is, as mentioned, quite complex). They broke out features from their plugins.js and properly enqued them the WP in the themes function.php. Yet, it still doesn't work, the profile tabs won't respond. I spent some time on my own then trying to figure out what was going on and only when I commented out all possible enqued jquery instances did the tabs respond.

As I am not sure how many of our students would and will actually edit their profile on a mobile device, I don't have any feedback yet, I feel that the effort has reached a questionable ROI time wise. So as a last ditch effort I looked at the Unified theme itself. I oped up spProfileEdit and noticed that there are two separate functions for editing the profile, one for mobile and one for desktop. So I figured I'll simply change

                if ($spDevice == 'mobile') {

                    sp_ProfileEditMobile();

                }

to

 

               if ($spDevice == 'mobile') {

                    sp_ProfileEdit();

                }

And waddaya know, it works like a charm. Sure it doesn't quite look as pretty as the native mobile edit but it does work and since it's surrounded by the mobile theme there's no visible difference to the user, except that tabs are on the left and are bit squished depending on the screen orientation.

So that's the solution.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jul 7, 2015 - 4:39 am

Would be nice to find the problem though. There is still clearly some sort of conflict at play. As to the theme authors then good for them. We have encountered others in the past who just dismiss the whole thing ot - worse - do not even bother to respond at all.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Thorsten B
Member
sp_UserOfflineSmall Offline
Jul 7, 2015 - 2:00 pm

I agree, but it is difficult to troubleshoot with current mobile tools. Unfortunately my time is limited and the issue might only effect a very small percentage of users so have to leave it at that for now.

Avatar
Ike
Sawtry, UK
Member
Free Members
sp_UserOfflineSmall Offline
Jul 7, 2015 - 5:53 pm

Agreed, it's a tough one. Do let us know when and if you want to re-investigate, although Andy or Steve might have further questions.

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17361
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625