Support Forum
Support Forum
Offline
Mr Papa said
but to be clear, your image has a count of 1... if it was every page, should have been more... can you verify the count increments for every page and the image was not matching your words?
Perhaps you mean the notice I copied and pasted in post 7 above? My only other image above has a count of 380. The most recent count after clearing the log more than an hour ago is back up to 14...
27 June 2015 4:46 pm | spaErrNotice | 14 | php
file: /simple-press/sp-control.php
line: 98
function: sp_is_forum_page
Notice | Trying to get property of non-object
So the count is increasing, but nowhere near the increments expected if this was occurring upon every page load.
And perhaps unrelated, but there is this new similar notice for a different function.
27 June 2015 3:57 pm | spaErrNotice | 7 | php
file: /simple-press/sp-startup/forum/sp-forum-constants.php
line: 26
function: include_once
Notice | Trying to get property of non-object
yes, your option should disable our logging of them... quite odd that it doesnt - will open ticket for investigation...
Thanks! And here I thought I was just starting a simple topic where users could report insignificant notices...
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
Offline
of course I noticed the 380 - which is why I mentioned age.. and why I asked for it to be cleared and enumerated as pages were loaded... and if it increased for every page load...
thanks for the update... doesnt help understand how the wp page id would not exist though 🙂
have to wonder if some other plugin or widget is loading the forum content where perhaps it doesnt exist but doesnt display the content... still would think not a problem...
could give an easy check before the usage to make sure it doesnt exist, but since it seems it must, would just slow down the page processing (every so slowly)... so we want to understand before just perhaps covering up something else...
Visit Cruise Talk Central and Mr Papa's World
Offline
after doing some research, it appears the name of that option is a bit misleading... both the option name and the admin popup help appear to indicate all simple press notices would be hidden...
but in actuality, only notices of undefined index/variable will be suppressed... in this case, the notice is for trying to get property of non object... so its not suppressed...
will discuss around here if we want to broaden the suppression or clean up the option name/problem-with-post-edit-buttonelp so its more clear...
Visit Cruise Talk Central and Mr Papa's World
Offline
Mr Papa said
could give an easy check before the usage...would just slow down the page processing...
Well we wouldn't want that!
This doesn't seem to have any adverse affect that I can tell, so I can live with it while looking further into any sort of conflict.
only notices of undefined index/variable will be suppressed…
Thanks for the clarification!
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
Offline
Despite the fact that I have never seen this particular notice anywhere else and suspect - like Steve - that it is in all likelihood not being triggered on normal forum page loads as the count would be way, way higher and would climb quickly - I do support putting a check in place. Steve is correct that a check would be another stage in processing but - when the error does get triggered there is also the reporting and writing out of the condition that should be considered - a longer process.
Additionally - if we are correct and this is the result of, say, some sort of bot activity - and I do not mean by that something hostile - then killing the load process at that point if the data is not loaded would seem a more appropriate action.
But let's get some input and agreement on that from Steve before progressing...
 |
YELLOW
SWORDFISH
|
Offline
regarding the notices, we have made a change and that option will suppress all forum notices in the next update...
I would still prefer more data before deciding what to do... some debug data... maybe right before the line throwing the error, add
ashow(debug_backtrace());
ashow($wp_query);
and lets see where this is coming from... then on page load, look for a blue box with extra data in it...
Visit Cruise Talk Central and Mr Papa's World
Offline
Mr Papa said
ashow(debug_backtrace());
ashow($wp_query);
Are these results shown to all users and visitors, or just the admin account?
Assuming the former, I added the debug function on our dev install, and it looks like it does display to everybody, on every page. It also appears to break a couple pages, and the second box ($wp_query) always appears to be blank.
I temporarily disabled the Maintenance Mode plugin we have on our test site, so you can see this in action... http://tripawds.net/forums
After adding the code to sp_control I also get this error, with the number of occurrences increasing much more rapidly...
June 29, 2015 12:13 pm | spaErrNotice | 116 | php
file: /simple-press/sp-control.php
line: 98
function: include_once
Notice | Undefined variable: wp_query
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
Offline
that looks odd, almost an alternate way of loading wp (non standard)... perhaps by plugin or theme to get access to some wp data the wrong way... the call sequence does not really make sense at first glance... and would explain why wp_query is empty (since wp was loaded improperly)...
Visit Cruise Talk Central and Mr Papa's World
Offline
Mr Papa said
...the call sequence does not really make sense at first glance...
And it is totally Greek to me. Considering nothing is breaking, I'm not spending too much effort to fix it. Notices in the SP error log I can deal with. Hours of troubleshooting, not so much right now.
Unless y'all see any serious cause for alarm, I'm gonna have to table this one for a while. Thanks for all your thoughts on the matter!
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
All RSS1 Guest(s)