No matter what I try, I cannot replicate this behavior… the links work correctly for users with spaces in the user login name no matter what I try… both new users and existing users properly have the nicename with the dash (-) in them…
any more info you can provide? is your sp bp plugin up to date? any special BP plugins for registration, users or other?