Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
plugins-topic
Email module error
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 25, 2016 - 4:17 am

And I am going to dig into the html email code this morning to see if I can find any reason for that

andy-signature.png
YELLOW
SWORDFISH
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 25, 2016 - 4:42 am

I think I have the HTML Email issue resolved. We will push out an update pretty quickly after testing. If you want to edit the code for the fixes I can publish them here - there are two files affected.

Apologies for the problem. WordPress changed their change password core code a couple fo versions back and we clearly missed one change we needed to make to account for it.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 25, 2016 - 7:06 am

Just so you know, our mail server seems unable to send your emails (subscriptions) so we are getting a lot of bounced email notifications, No reason given in the messages we are getting back from the server.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 25, 2016 - 8:29 am

Yellow Swordfish said
Just so you know, our mail server seems unable to send your emails (subscriptions) so we are getting a lot of bounced email notifications, No reason given in the messages we are getting back from the server.  

Sent you a pm, withan alternative email address.

 

Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 25, 2016 - 8:30 am

Yellow Swordfish said
I think I have the HTML Email issue resolved. We will push out an update pretty quickly after testing. If you want to edit the code for the fixes I can publish them here - there are two files affected.

Apologies for the problem. WordPress changed their change password core code a couple fo versions back and we clearly missed one change we needed to make to account for it.  

Yes, please.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 25, 2016 - 11:07 am

It also means, of course, that you will be helping us test the fix - so thanks. OK...

Both files that need changes are in the HTML Email plugin. First file is:
html-email/sp-html-email-plugin.php

Around line 48 find this line of code:

add_filter('sph_user_new_user_email_subject', 'sp_html_email_new_user_subject', 10, 3);

and change that 3 at the end to 2.

Then down at line 324, change this function:

function sp_html_email_pw_change_body($msg, $key, $pw) {
    include_once(SPHTMLEMAILLIBDIR.'sp-html-email-components.php');
    $msg = sp_html_email_do_pw_change_body($msg, $key, $pw);
    return $msg;
}

To remove the $pw argument on the 1st and 3rd lines (as well as the comma before them of course)

The other file is:
html-email/library/sp-html-email-components.php

in line 101 find:

function sp_html_email_do_pw_change_body($body, $key, $pw) {

and again remove the comma and $pw at the end of the arguments to the function.

Hope that is clear...

andy-signature.png
YELLOW
SWORDFISH
Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 25, 2016 - 4:57 pm

Tried, not fixed. It doesn't save email text and continues to ignore any changet to text.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 25, 2016 - 5:08 pm

Are we still talking about the password reset email?
Are there any errors in the error log (Errors only - the pink ones!)

andy-signature.png
YELLOW
SWORDFISH
Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 25, 2016 - 7:08 pm

Yellow Swordfish said
Are we still talking about the password reset email?
Are there any errors in the error log (Errors only - the pink ones!)  

Yes.

Only this

26 maggio 2016 00:20 | spaErrError | 35 | database


file: /web/htdocs/www.mycuco.it/home/wp-content/sp-resources/forum-plugins/keywords/library/sp-keywords-components.php
line: 79
function: spdb_table
error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

SELECT * FROM wp_sfposts WHERE post_id >

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
May 25, 2016 - 7:49 pm

that is an interesting error but unrelated...  unfortunately, I am on the road without easy access to the codebase to help much...  and Andy is likely gone for the day (in UK)...

Did you 'use' his code or type it manually?  if the former, did you use the view raw code button and copy? otherwise you might have gotten some different characters...

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17362
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625