Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
plugins-topic
Email module error
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 26, 2016 - 2:03 am

No - there is still an issue remaining @mr-papa - I have missed something. Will dig in this morning

andy-signature.png
YELLOW
SWORDFISH
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 26, 2016 - 2:26 am

Somewhere along the line we seem to have accidentally lost 2 lines of code here. I will go back and see if I can find why but at least we can get you back to working properly first.

This time the file is:
/html-email/admin/sp-html-email-admin-pw-change-save.php

Before the call to the function sp_update_option() near the bottom, add these two extra lines of code:

$option['pw-change-subject'] = sp_filter_save_escape(sp_filter_save_nohtml(trim($_POST['pw-change-subject'])));
 $option['pw-change-body'] = sp_filter_text_save(trim($_POST['pw-change-body']));

and hopefully, this time, we HAVE nailed it!

andy-signature.png
YELLOW
SWORDFISH
Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 26, 2016 - 2:37 am

Mr Papa said
that is an interesting error but unrelated...  unfortunately, I am on the road without easy access to the codebase to help much...  and Andy is likely gone for the day (in UK)...

Did you 'use' his code or type it manually?  if the former, did you use the view raw code button and copy? otherwise you might have gotten some different characters...  

I wrote manually, using notepad. In file there is $pw also at line 312 and 314, have I to delete also in these lines?

Please note: I can't change the text in any way, also if I type "hello world" and save.

Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 26, 2016 - 2:53 am

Yellow Swordfish said
Somewhere along the line we seem to have accidentally lost 2 lines of code here. I will go back and see if I can find why but at least we can get you back to working properly first.

This time the file is:
/html-email/admin/sp-html-email-admin-pw-change-save.php

Before the call to the function sp_update_option() near the bottom, add these two extra lines of code:

<br />

$option['pw-change-subject'] = sp_filter_save_escape(sp_filter_save_nohtml(trim($_POST['pw-change-subject'])));
 $option['pw-change-body'] = sp_filter_text_save(trim($_POST['pw-change-body']));

<br />

and hopefully, this time, we HAVE nailed it!  

Done, but, sorry, no good news: still can't change any word. As I wrote to Mr Papa, $pw is in lines 312, 314, too. Have to delete?

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 26, 2016 - 3:38 am

Oh dear - I really wasn't having a good day yesterday was I...

It was the two $pw instances at lines 312 and 314 that I meant to ask you to remove. I pasted the wrong function into the post. But that doesn't matter as the function I pasted in doesn't have the $pw so there was nothing to remove. I assume you did not remove anything from the function I stated yesterday but please nopw do remove the $pw from 312 and 314,

I said earlier that the change password email seemed to be working for us but I was mistaken hence this mornings changes. And these are really a separate issue. However, those two extra lines have fixed it in my tests. You did put them just BEFORE the call to sp_update_option() - yes?

andy-signature.png
YELLOW
SWORDFISH
Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 26, 2016 - 4:23 am

All done, but no way. Could you please send me your full plug-in dir? I could try to upload it by http://ftp....

Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 26, 2016 - 4:40 am

In sp-html-email-plugin.php

line 49

add_filter('retrieve_password_title',                   'sp_html_email_pw_change_subject');

all other lines have numbers. Have I to add something?

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 26, 2016 - 4:46 am

I have sent you a PM

andy-signature.png
YELLOW
SWORDFISH
Avatar
Stefania
Member
sp_UserOfflineSmall Offline
May 26, 2016 - 8:39 am

All done. Now it works.

Great support!!

Thank you!!

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
May 26, 2016 - 9:29 am

Oh.. I think I just get a B- for this one 🙂

andy-signature.png
YELLOW
SWORDFISH
Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626