Support Forum
Support Forum
Offline
Edit: Topic should be "Filter idea" not hook. Sorry.
Is is possible, or reasonable to consider adding a second argument to filters that are near the end of a function?
Example: apply_filters('sph_ProfileEditButton', $out) allows you filter, modify or even replace output before it's returned. I'd like to see apply_filters('sph_ProfileEditButton', $out, $a) so the arguments are exposed for lot's of reasons. I'm loving we are usings wp_parse_args. And that we can add unlimited extra args because of it. But it's wasted if we can't access the args later. 🙁
Offline
it is a hook... filters and actions make up hooks... 
I thought we had put the args array in most of those template tags hooks... I agree they should be there - the one you reference clearly is not...
will trawl through them and add...
Visit Cruise Talk Central and Mr Papa's World
Offline
If it wasn't kinda creepy... I'd hug ya. [Image Can Not Be Found]
Thanks!
Offline
looked like about 50% had them and 50% did not... that will teach us to follow our own standards! 
Visit Cruise Talk Central and Mr Papa's World
Offline
Aaaaaaah.... that move just allowed me to delete a ton of hacky code that allowed me to detect if it was my plugin calling the functions or not.
Much more better!
Offline
I haven't updated source code yet but have these been added to the filter prior to the echo?
I like the idea of that but we have to remember that at that point the $a contents are not sanitised.
 |
YELLOW
SWORDFISH
|
Offline
Can't vouch for each of them, but so far I'm finding them prior to the echo. Will keep in mind about sanitizing. Something to remember to add to the faq, wiki, codex or whatever we are going to use to document.
Offline
yes, they are before the echo.. and yes, users need to sanitize - good point to document... this is just like the filter on the args themselves...
Visit Cruise Talk Central and Mr Papa's World
Offline
I am so loving the change!
However I had forgotten how to add_filter for extra arguments. A new pot of coffee is a Godsend.
For the boneheaded like me, this example will handle one argument (most common usage):
add_filter('sph_ExampleFilter', 'myExampleFilterFunction');This example will handle 2 args. Edit '2' to handle more if filter supports:
add_filter('sph_ExampleFilter', 'myExampleFilterFunction', '', '2');
All RSS1 Guest(s)