Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
plugins-topic
"Polls" plugin - "Hide Poll Results Until Closed" in unselectable
Avatar
Hulk1977
Member
sp_UserOfflineSmall Offline
Aug 18, 2016 - 5:11 am

Hello,

Here's how it looks:

bug3.jpgImage Enlarger

Nothing happens when I click "Hide Poll Results Until Closed" and there's no checkbox or anything next or below it, so there's no way to enable "hidden post results". Tested in latest Firefox and Chrome.

 

* in unselectable = is unselectable

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 18, 2016 - 8:20 am

there is no checkbox or action associated with that. It is simply information about how you have the poll options set up. So you can change that in the poll options and the information message will disappear.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Hulk1977
Member
sp_UserOfflineSmall Offline
Aug 18, 2016 - 12:32 pm

Sorry but this is not how the plugin is described in the Codex

https://simple-press.com/docum.....ins/polls/

 

Click the check box to the left of “Allow poll results to be hidden” to select this option. This gives the poll creator a choice of whether or not to hide the poll results until the poll expires. After the poll expires, the results are visible in the post.

 

So each new poll must have an option, to be decided by its starter, either to make results hidden or not.

 

And this is what context Help says:

Also, you can choose to allow polls results to be hidden until the poll is closed. If this option is enabled, when creating a poll, users will be able to have the results hidden until the poll is closed.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 18, 2016 - 1:14 pm

You are correct. Looks like a javascript issue. Have put in a fix which I am happy to post here if you want to edit your file although we do need to put out a small update pretty quickly.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Hulk1977
Member
sp_UserOfflineSmall Offline
Aug 19, 2016 - 2:30 am

Will be happy to see both the fix and the update 🙂

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 19, 2016 - 9:46 am

The file is in the forum plugins folder /polls/ajax/sp-polls-ajax-create.php

At line 76 the code currently reads:

if ($polls['hide-results']) {
    $out.= '<br /><div class="spEditorTitle">'.__('Hide Poll Results Until Closed', 'sp-polls').'  ';
    $out.= '<input type="checkbox" class="spControl" name="sp-poll-hide" id="sp-poll-hide" /></div>';
}

And this needs replacing with:

if ($polls['hide-results']) {
    $out.= '<br /><div class="spEditorTitle">';
    $out.= '<input type="checkbox" class="spControl" name="sp-poll-hide" id="sp-poll-hide" checked="checked" />';
    $out.= '<label for="sp-poll-hide">'.__('Hide Poll Results Until Closed', 'sp-polls').'  </label>';
    $out.= '</div>';
}
andy-signature.png
YELLOW
SWORDFISH
Avatar
Hulk1977
Member
sp_UserOfflineSmall Offline
Aug 19, 2016 - 11:33 am

Thanks, I will try it. Also I hope for an official update, as currently the description of the plugin in the Codex is misleading.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 19, 2016 - 11:43 am

I will pass it on but it is odd because it was you quoting the codex (and popup help) that prompted me to dig deeper and look into the code (which I did not write).

andy-signature.png
YELLOW
SWORDFISH
Avatar
Hulk1977
Member
sp_UserOfflineSmall Offline
Aug 19, 2016 - 1:01 pm

I'm quoting it, but I didn't write it, right? So, what do you find "odd" exactly? Am I quoting it wrong?

Also, I do not know (or have any obvious means to know) which one of you wrote what. I thought this was a support forum: I report a bug - I am offered a solution. What's odd about what? Seems pretty normal to me.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Aug 19, 2016 - 7:18 pm

I dont understand your comments...

Andy said you quoted the codex which is what prompted him to look into the implementation... nothing regarding your raising the issue??

the support forum is manned by the developers... no one else - though we do have some users that chime in occasionally...

I also do not see a solution??  maybe just missing it...  do you actually have a wording change suggestion for the codex?

We hope to push out an update to the polls plugin tomorrow to correct the missing checkbox issue raised in the last release due to our javascript overhaul...  certainly do appreciate you bringing that to our attention!

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17362
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625