Support Forum

Also I wonder if the problem could be related to the $replyto = apply_filters() call. No other code in my installation refers to the tag: 'sph_subscriptions_email_replyto' at all, so I wonder if I'm missing a necessary component for $replyto to actually be populated or if somehow this is an incorrect tag?

Not sure--just speculating. I am still very new to PHP and WordPress so I'm very much guessing here.

Thanks!

I understand--I would rather the From be from the forum-specific address anyway.

Current Settings

I believe the forum-specific email is set correctly. It's in the sfforums table in the forum_email column, in the UI, and also the little code test I made picks it up correctly when it sets reply-to.

Here are the settings for Forum/Options/Email settings in this screenshot (password blurred of course):

https://www.evernote.com/shard.....75271eb835

And for the forum itself in this one:

https://www.evernote.com/shard.....42e87c39f1

SMTP Plugin

Open to testing the SMTP plugin, although I'm not sure why it would make any difference. I will try it in a bit.

Code That Sets From?

Finally, my casual trip through the code doesn't reveal where the From address is being set by either PBE or Subscriptions. If convenient, I'd appreciate a pointer to where it is being set. Knowing that, maybe I can help resolve the issue with some tactical debug logging.

Thanks!

Ah, that certainly sounds like it could be the problem.

Forgive my apparent blindness, however. I still do not even see the option there. I'm looking at the Forum/Options/Email Settings page, which includes three sections: New User Email, Email Address Settings, and Post By Email Settings.

I don't see any option on that page that refers to 'Use forum email settings'.

Oh, I had that turned off thinking that was what was making PBE use the global setting and not the per-forum From address.

Turning it back on now and testing, it is using the email address specified in Email Address Settings as the From address. This is not surprising, but it's also not what we want, right? We want the From address to be the forum-specific address.

In other words, the post I just received has this as its From header:

From: Phit-N-Phat <corinne@phit-n-phat.com>

And no Reply-To header (I removed the small code mod I had made).

And shouldn't it be the following for replies to work?
From: Phit-N-Phat <tech.support.issues@phit-n-phat.mailgun.org>

Should I blank out 'The email from name' and 'The email domain name' values so that it will pick up the forum-specific values maybe?

Thanks!

No change in behavior after applying the change. That 'sph_subscriptions_email_replyto' string is mysterious to me anyway, as referenced above. No other code references that filter tag, except for the sp_subscriptions_do_post_notifications() function and the code just added. And there is no function by that name.

So Reply-To here is still empty, which leaves only the sfmail options account as the From and therefore no forum-specific addresses.

It looks to me like sp-subscriptions-components.php/function sp_subscriptions_do_post_notifications() wants a real ReplyTo where it says:

# send the notification
$replyto = apply_filters('sph_subscriptions_email_replyto', '');

And so PBE should register a filter function on 'sph_subscriptions_email_replyto' to give it a forum-specific reply-to value. And maybe the same logic would apply for From values (not sure if filter ordering would make this tricky).

I see where you would not want to do the hack that I did to always give a forum-specific reply-to inside of the subscriptions code--this is exactly why you would want PBE to register its own filter, I think. (I have not actually gotten to filters yet in my PHP/WordPress learning, but that's my suspicion).

Thanks!