Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
plugins-topic
Spam Registrations: delete from SP or database?
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Mar 23, 2012 - 5:33 pm

...and thanks for testing the fix for us, Well - and finding it in the first place of course

andy-signature.png
YELLOW
SWORDFISH
Avatar
MartiL
Member
Free Members
sp_UserOfflineSmall Offline
Mar 24, 2012 - 6:17 am

Finding it was easy, you're doing all the work 😉

Anyway, I've been testing things this morning and it all works fine, except for where deleted users end up: can't find them in Members With No Memberships (where they should be) or any of the other usergroups. Their account is simply not found.

(Guess this makes sence since the edit we did in the second post of this thread?)

So far so good, but I took one of the accounts and logged on as a 'deleted' user. Turns out they seem to be in the default usergroup for new members. Which is where most of them were to begin with wink So they can still access the forum just like all free users ...

(Seem to be: they're not listed when I hit 'show members', but once I log in they have the new users permissions.)

Any thought on what/problem-with-post-edit-buttonow to edit so those users go to eighter Members With No Memberships or a usergroup I'll create, so they don't have forum access anymore?

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Mar 24, 2012 - 7:10 am

OK - hands up - that was my fault and mow I am feeling totally stupid. I didn't think this through.

The removal tool is, of course, geared to total removal. But you wanted to keep these users in the WP end - hence the commenting out of the two sql delete statements.

What I overlooked - and actually had totally forgotten about - is that you have to remember that login is controlled by WP. If, when a forum page is loaded, SP detects a logged in user who has NO record in the SP sfmembers table - then it creates it on the fly. It assumes that this is an error condition and rectifies it - going through the same process as it would when a new user registers.

So - if such a user does not login then they are NOT in any user group and as far as SP is concerned, do not exist. But the minute they log in - wham - we set it all up for them!

Whether we need to, perhaps, make that an option in the forum admin members panel, is something that needs some discussion.

As it is - I am sorry - but that is now where the data stands for those users. To stop it from happening would require  core code change of course.

Another word for this is whoops!

andy-signature.png
YELLOW
SWORDFISH
Avatar
MartiL
Member
Free Members
sp_UserOfflineSmall Offline
Mar 24, 2012 - 7:36 am

Darn, I should have figured that out for myself - I know SP creates the tables on the fly, that's one of it's nifty features. And to be honest, if that were to become optional I'd leave it on laugh

Would it be possible to leave SP as is and have the plugin move members to a certain usergroup, not delete them? As you've no doubt noticed, coding is not my strong suit (I'm going for the understatement award here) so forgive me if I'm asking you to basically rewrite a plugin, thinking it's a minor change embarassed

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Mar 24, 2012 - 8:50 am

Actually that would be a fairly minor change and quite a useful option. We will need to discuss this end of course but I will open a ticket on it anyway...

andy-signature.png
YELLOW
SWORDFISH
Avatar
MartiL
Member
Free Members
sp_UserOfflineSmall Offline
Mar 24, 2012 - 10:16 am

Thank you ever so much!

I feel a bit quilty taking up so much of your time - I'll stop asking questions now and patiently await the 'Spam Plugin Verdict' laugh

Since I was able to tweak the forum a bit, thanks to the absolutely amazing support you guys give, my users are now quite the happy bunch again ... Which makes my life a *lot* easier!

Thank you both so much for that! And I'll see if I can find more ways to give back a little to the plugin and the community.

Off for now, I'm told it's nice and sunny out there in the real world 😉

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Mar 24, 2012 - 12:48 pm

sunny and 85 today here!  but that's quite normal... wink

thanks for the kind words!

Avatar
MartiL
Member
Free Members
sp_UserOfflineSmall Offline
Apr 1, 2012 - 9:45 am

I just installed the update - thanks guys! I'm about to do some "lurker cleaning" laugh

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Apr 1, 2012 - 10:13 am

... then I hope I got it all right!

andy-signature.png
YELLOW
SWORDFISH
Avatar
MartiL
Member
Free Members
sp_UserOfflineSmall Offline
Apr 1, 2012 - 10:29 am

I think it needs a little tweak somewhere; the users remain in their original usergroup ... Sorry 😉

lurkers-1.pngImage Enlargerlurkers-2.pngImage Enlarger

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17362
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625