Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
themes-topic
Allow the Group Name to collapse the Forum Listing - spGroupView.php
Avatar
Peder Karlsen
Member
Free Members
sp_UserOfflineSmall Offline
Feb 27, 2013 - 2:55 am

Hi

I am not so good in code so I do always look at the new theme before I do any update to make shore I get it in the right place. When updating the spGroupView.php the changes in the default theme do not match the changes in your documentation.

The new line in spGroupView.php is Line 37

if (function_exists('sp_ShareThisTag')) sp_ShareThisTag('tagClass=ShareThisTag spRight');

But your documentation tells me to add this.

Template: spGroupView.php
Function: sp_GroupHeaderName()
Arguments added:
1
2
3
'toggleTagId' => 'spGroupOpenClose%ID%',
'collapse' => 1,

So what is the right thing to add the spGroupView.php?

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Feb 27, 2013 - 3:08 am

You've lost me here I am sorry to say. What has the sp_ShareThisTag() function got to do with the sp_GroupHeaderName() function? The latter being the one to change...

andy-signature.png
YELLOW
SWORDFISH
Avatar
Peder Karlsen
Member
Free Members
sp_UserOfflineSmall Offline
Feb 27, 2013 - 3:38 am

I am just looking at the difference between the default theme and the custom theme I did make 3 weeks ago form the default theme. And I cannot find the change you write about in http://codex.simple-press.com/.....tes-5-2-3/ in the new default theme.

But line 37 has change in the last 3 weeks, and the change there is not in the documentation.

So should I add line 37? And way isn’t the change in the documentation in the new default theme, if I should add it?

I do se some writing about the ccs so I do only want to be certain about the changes.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Feb 27, 2013 - 5:23 am

OK sorry - must have been too early for me to think straight!

Firstly the change to the Group name function is optional. The default is for it to be turned on so if you want it on there is no need to change anything which is why the supplied templates do not include it. But you WOULD need to add it if you prefer it to be turned off. This is why the actual function def was shown in the codex - not the template call itself.

The other changes are simply bringing template functions from plugins into the theme templates. We had this odd mix where some were included and newer ones were not so simply bought them up to date. These are all optional and only needed if you install and activate the actual plugin(s).

andy-signature.png
YELLOW
SWORDFISH
Avatar
Peder Karlsen
Member
Free Members
sp_UserOfflineSmall Offline
Feb 27, 2013 - 8:51 am

Thanks for the clarification!

 

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Feb 27, 2013 - 6:07 pm

np. glad we could help!

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626