Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
themes-topic
Column and row dividers (like V4.5)
Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Jan 13, 2012 - 6:00 pm

Hello on my V4.5 simple press installation there are some very subtle column and row dividers (borders) in both group and forum view. I'd like to see how these look with my V5.0 theme. What would be the best way of turning these on, if indeed they can be turned on. If not what would be the most expedient way of generating them?

Conrad

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 13, 2012 - 8:34 pm

you would have to add the css for them... add borders...

spColumnSection for columns though you might want to be more specific... and you will need to use firefox and firebug for the rows you want to do it on to narrow down...

Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 9:23 am

I have dismally failed to get this working.

I added the following code in the default.php for the theme:

#spMainContainer .spColumnSection {
     margin: 0;
     padding: 5px 0 0 0;
     border-right:1px dotted silver;

If I comment out the last line above the columns behave perfectly well and the site looks good, like this.

Image Enlarger

 

 

With the line in I get this:

 

Image Enlarger

 

 

I have tried everything, padding etc. I don't actually understand what is causing it at all. The column percentage are unchanged and add up to 100%.

I probably won't have the borders there anyway but I would like to have a look at the effect and I would like to understand what is causing the problem.

 

Conrad

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 11:04 am

the numbers wont be able to add to 100%...  remember the border and margin/padding may take up additional space...

easiest way to do it is using firefox and firebug...  what if...  add the border, margin, padding, etc until it looks the way you want...

Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 7:17 pm

Can you imagine what a revelation it was to me when I read this. Oh of course all the elements are involved so there might not be space. Hard to imagine that adding 4 px in total in a container could cause me such mayhem.

I have set the right border to 1px dotted silver for all spColumn sections in default.php like this:

#spMainContainer .spColumnSection {
    margin: 0;
    padding: 5px 0;
    border-right:1px dotted silver;

whereas in reality all I want is the columns in Group and forum view to have the treatment. I couldn't figure out how to pass the border commands in the spGroupView.php or the spForumView.php so if this can be done a small piece of sample code would be nice.question

I have a similar problem in the profile permissions pop up where all the spOdd sections are misbehaving. I know how the columns and padding work now but I can't figure out where the problem is being generated.

Here's another screen shot from yours truly, notice how the second group 'Technical Stuff' is OK, the third group behaves like the 'Members Forum' group.

Image Enlarger

Avatar
Brandon
U.S.
SP Wrangler
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 8:20 pm

There is something before the first group causing a problem. Something wasn't cleared out before it is shown. You can add a div class=clear: both; and that would remove the previous formatting.

Avatar
Brandon
U.S.
SP Wrangler
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 8:31 pm

Conrad_Farlow said

whereas in reality all I want is the columns in Group and forum view to have the treatment. I couldn't figure out how to pass the border commands in the spGroupView.php or the spForumView.php so if this can be done a small piece of sample code would be nice.question

I would think, that as an example, in spGroupView you should see the different columns.

IE,
# Column 1 of the forum row
                        # ----------------------------------------------------------------------
                        sp_ColumnStart('tagClass=spColumnSection spLeft&width=6%&height=55px');

It should add the border if you did something like this.

                        sp_ColumnStart('tagClass=spColumnSection spLeft&width=6%&height=55px&border-right=1px solid silver');

You would have to add in the border to all the columns as needed then probably adjust the width % to make up for the additional borders.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 10:41 pm

no. you cannot pass in the border like that... those template tag arguments are not css styles... they are essentially variables passed to the php function...  anything you try to pass in must be 'expected' on the other end, or they will just be ignored...  and we are not looking for a variable called border-right...

keep in mind the left side of = is the variable name and the right side is the value...  but again, these are php variables not css...

so in this case, you want to pass something in tagClass variable...  this will be added to the css class for the element... then you would add css styles to the class...  so you can add new styles to spColumnSection or add another class (there are two already spColumnSection and spLeft) and style that one if you want something more specific than the generic column class...

Avatar
Brandon
U.S.
SP Wrangler
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 11:13 pm

Dang, thanks for the heads up. It appeared simple in FF and Firebug but that makes sense now that you explain it.

Thanks for piping in.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 14, 2012 - 11:35 pm

no worries.  thanks for jumping in - keep on doing it... best way to learn!

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626