Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
themes-topic
CSS only theme issue displaying toolset on topic view
Avatar
Bill Murray
Member
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 11:29 am

I came up with an odd issue with the CSS only theme, which I am modifying.

Logged in as an administrator, the toolset button appears essentially at the left margin of the browser on a topic view (other views are ok), but it only appears when I hover in a certain area, which is hundreds of pixels away.  As a result, I'm not fast enough to get to the toolset button before it disappears. 

It's for this ID/class: #spMainContainer a.spToolsButton

Changing the left margin by a huge amount does get it closer.  Is that a glitch in the CSS only theme or is it something caused by my general theme or some other change I've made to the CSS only theme?

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 11:43 am

you are probably missing some updates to the css only theme... 

http://websvn.simple-press.com.....1&;

in particular, you want the ones for the signature changes...

#spMainContainer .spTopicPostSection {
    color: #4c5d77;
    background: #eff3f8;
    border: 1px solid #dddddd;
    margin: 2px;
    overflow: hidden;
    padding: 0;
    -moz-border-radius: 5px;
    -khtml-border-radius: 5px;
    -webkit-gradientborder-radius: 5px;
    border-radius: 5px;
    position: relative;
}

and

#spMainContainer .spTopicPostSection .spPostUserSignature {
    font-size: 90%;
    padding: 20px 0;
    margin: 0;
    border-top: 1px solid #DDE8EE;
}

I think its the first one that is causing the mis-alignment...

Avatar
Bill Murray
Member
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 12:19 pm

I have 1.0.5 of the CSS only theme installed, but I may have goofed and started my development of my custom theme from an earlier revision of the CSS only theme.

Are those the only changes to the theme since whatever came in the beta for WP 3.3?  It's easier for me to make those small changes than start over from a current copy of 1.0.5.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 12:54 pm

that list is all the changes that fits on 2 pages... wink and goes back some time...

if you have some idea when you created yours, you can move forward from there...

thats a problem with being in alpha or beta... things will change... with RC rapidly approaching, we should hopefully be done with changes to themes unless a major bug pops up... and moving forward, we will have to be very, very wary of changes that affect existing themes... backwards compatibility will be king... when we update sp, ideally, any existing sp themes should keep chugging along fine... of course, you may not get at new features, but the existing stuff needs to work...

Avatar
Bill Murray
Member
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 1:56 pm

Those changes fixed it.  Thanks.

On your alpha/beta comment, if you update the theme, don't you change the version # and have some change log?  I know the theme is updated from the fact that WP shows me there's an update.  So, whether it's a major or minor bug, as long as you change the version # to trigger the updater and document things in a change log, all is good going forward.  If you update SP and the update breaks a theme, people complain, and the theme updater kicks in.  It's a nice model.

One unrelated comment on the CSS: there was an extended discussion on the Genesis forums about the order of lines in CSS, and the take away from that was to order alphabetically, except that a) top, right, bottom, left should always follow position and b) height should always follow width if those declarations are present.

I've gotten used to that approach, so for the theme I'll contribute, I'm adopting it.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 2:34 pm

yes, when we update our themes and push out an update, we update the version number... so you will know we updated our theme...

we have historically used websvn (the site I linked to) for our changelogs...  but we have been discussing additional ways to make the changes known or viewable...  no final answer yet...  but you are right, the updater will alert you that something changed in the core themes...

order what alphabetically?  the styles themselves? right to left alpha?  or do you just mean the attributes within the styles?

Avatar
Bill Murray
Member
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 5:20 pm

Just the attributes within the styles.

It's a not a huge deal, but I have been working with Genesis for a while and have adopted this approach as well, so looking at the SPF css made me think the house had been ransacked while I was out.  rolleys

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Dec 27, 2011 - 6:22 pm

I dont disagree at all... but then again, not likely to spend the time at this point, alphabetizing... I had spent some time looking for a tool that would do it for me, but alas, all the ones I found choke with the php code in all the themes but css only...

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626