Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
themes-topic
Jquery issues When using a RocketTheme wordpress theme on guest View
Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jul 6, 2013 - 2:26 am

login_head is to used to let plugins or themes hook into the login form process... without it, anything that needs to hook into login form processing, may not be able too... might not be an issue for your site...

but your code change is pointless as made... you would be better off removing the line of code... as you changed it, you will just be wasting cpu cycles...

so, yeah, like I thought its the inline login form... oddly, not quite the way I thought though... think this is the first time we have run into a plugin that is loading js via that hook (which it probably should be able to) that is causing problems... loading js in the middle of the page is technically not correct, but can work...

in this situation, your theme or plugin is still not loading the js correctly... and our use of that action has exacerbated the problem... so what happens is gantry is trying to load the mootools js in the head tags via that action... when we call it later, it loads it later... this causes problems for other js that has a dependency on the mootools... so really, gantry should be specifying those dependencies since the wp enqueue stuff supports it... in other words it should load the js that depends on the js loaded in the login_head action after the needed js is loaded... they just made an assumption it would be loaded.. assumptions like that are bad ;) the fact that we fired the hook in the body instead of the head tags, made the issue come to light...

so it would be nice if gantry would use the wp js loading api and specify dependencies rather than blanket loading stuff and making assumptions.. Frankly, the api is there for a reason...

that said, on the other hand, we need to take a look at our use of that action too since its really supposed to be in the page head tags so plugins/themes can load js... we may want to clean up our end too...

Avatar
Lee Erickson
Member
sp_UserOfflineSmall Offline
Jul 11, 2013 - 1:34 pm

I will show them this thread, but there are quite a few screwy things about Gantry honestly. For now would it be possible to add a simple if php statement option to disable the login_head part of the feature so that it would be something that I would not have to update time after time? 

Because this is something that ALL rocket theme users will face as I tried MANY different rocket themes and they all had this problem. Again, I didn't build the themplate rocket themes did using their Gantry framework.

I know it is alot to ask, but please give it some consideration. :)

Thanks for all your help! :)

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jul 11, 2013 - 2:34 pm

We will be removing that filter call and swapping it for one of our own so you can get rid of it with no problem. It wont come back on the next upgrade...

andy-signature.png
YELLOW
SWORDFISH
Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626