Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
general-topic
Pop Up Windows Not Closing
Avatar
scotchpotch
Scotland
Member
Free Members
sp_UserOfflineSmall Offline
Jan 1, 2012 - 11:30 pm

Hi

 

If the 'view edit history' or 'policy policy' are selected, or anything that shows a pop up window, the window cannot be closed unless you refresh the screen, there is no X on the top right of the box to enable it to close.

 

Forum link

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 1, 2012 - 11:44 pm

you sure? there is here...

Avatar
scotchpotch
Scotland
Member
Free Members
sp_UserOfflineSmall Offline
Jan 1, 2012 - 11:53 pm

Yes, I'm sure

 

Does not seem to work on my theme, did you try my forum link?

 

Did the pop ups on my forum close for you?

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 2, 2012 - 12:05 am

yup. its there in the upper... 

however, in you sp theme, you removed the styles for the icons

.ui-dialog .ui-dialog-titlebar-close

should have an icon in there...

.ui-dialog .ui-dialog-titlebar-close {
    background-image: url("images/close.gif");
    height: 18px;
    margin: -10px 0 0;
    padding: 0;
    position: absolute;
    right: 12px;
    top: 14px;
    width: 18px;
}

did you lose that style?  or perhaps your theme is not providing them like our provided themes...

Avatar
scotchpotch
Scotland
Member
Free Members
sp_UserOfflineSmall Offline
Jan 2, 2012 - 12:16 am

hmmm, curious

 

Here's my code...

 

.ui-dialog .ui-dialog-titlebar-close {
    position: absolute;
    right: 12px;
    top: 14px;
    width: 18px;
    margin: -10px 0 0 0;
    padding: 0;
    height: 18px;
    background-image: <?php echo($ImageClose); ?>

 

And you will notice that the image close is on the last line - I've never touched this code so I'm assuming that maybe the original default theme has been updated?

 

Anyway, copied your code onto my theme - and it works fine.

 

Thanks for your help on this one.

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 2, 2012 - 12:21 am

is ImageClose defined in your overlay file? if not that would be the reason...

Avatar
scotchpotch
Scotland
Member
Free Members
sp_UserOfflineSmall Offline
Jan 2, 2012 - 12:31 am

Using your code, it all works fine though.

 

Nothing on the overlay for ImageClose

 

Your code: background-image: url("images/close.gif"); at the top of the routine.

 

My code:  background-image: <?php echo($ImageClose); ?> at the bottom of the routine - PHP within PHP?

 

As I've said, it works fine now.

 

Off to bed now, 6.30am in the morning here.

 

Thanks again

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Jan 2, 2012 - 12:34 am

that was my point... the php echo says its getting the value of ImageClose from the overlay... so thats why no image if you did not define it in your overlay...

any php statements in your main css file (.php) need to have that variable defined somewhere or it will be blank...

Avatar
scotchpotch
Scotland
Member
Free Members
sp_UserOfflineSmall Offline
Jan 2, 2012 - 5:49 am

I've checked the overlay file.

 

I had adapted the berries-n-cream.php overlay, calling it HoneyGold.php and stored a copy locally in case it was overwritten, which indeed it was. When I upgraded to 5.0, I copied my new overlay over.

 

On checking the current copy of berries-n-cream.php, I notice it is completely different from my adapted version. So you are right when you advised that ImageClose was not defined on my overlay.

 

The berries-n-cream.php I had adapted was the 4.5 version. I'll make a new version of my overlay using the up to date berries-n-cream.php

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Jan 2, 2012 - 6:05 am

Sounds like a 'beta' issue in that we do still need to make the odd change to files like overlays and themes prior to a full and final release. They are getting more and more stabilised however as we get nearer to this.

andy-signature.png
YELLOW
SWORDFISH
Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 620
Members: 17365
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10128
Posts: 79626