yup confirmed…  best thing about alpha versions…  fixing or adding stuff always seems to break stuff that has been working…

ticket open…

Some movement on this and I thought that you would like to know.

When the subscribe button is activated in the editor I no longer see any error script pop up. In addition I am getting email notification upon subscription. The button next to the RSS button at the bottom in topic view is toggling subscribe/unsubscribe and is functioning correctly.

In the editor options when you are subscribed to a topic the message ‘Unsubscribe from this topic’ appears but the indicator is on green when you are subscribed – this is counter intuitive and I am pretty is sure not what you intended. I would expect the message to appear but be on red for not selected. Changing it to green should unsubscribe I would have thought. If the green indicator for ‘Unsubscribe from this topic’ is left alone then no action results.

Conversely if you are not subscribed and open an edit window then the ‘subscribe to this topic’ message appears and behaves exactly as expected. It appears with the red indicator on and changing the indicator to green results in a successful subscription.

Finally in the header the Subscribed X with the ‘Review subscribed topics’ tooltip just does not work. There are never any topics to review when I click on this link.

This is at svn up 6855

All sounds good… Thanks for the feedback as usual.

Green just means ‘on’ or ‘select this option’. Red means turn it off. So isn’t that right? By unsubscribing am I not turning something off?

When you say the Subscribed button in the header ‘just does not work’ can you give a little more detail? Remember this is only going to report when there is a new post in a topic you are subscribed to but there should at least be a message when you click on it if there are no unread posts…

Mmmm I think that we disagree about the unsubscribe indicator light. The message says ‘Unsubscribe from this topic’  and I would expect the green light to be affirmation that you want to Unsubscribe just as a green light is affirmation that you want to subscribe when you are not subscribed to that topic. That would then be consistent.

When I say just does not work I mean that I cannot see any useful function from it at all. Surely it should have a list of subscribed topics then when the list is opened there should be a flag or something similar that indicates whether there are new posts there on each individual subscribed topic.

However if I understand you correctly then it is not working how you describe either.

I log on as MemberA and post something in a topic called ‘subscribe test’. Member B, another user, is subscribed to that topic but is currently not logged in. I log in as Member B on another browser and would expect to see at least Subscribed 1 in the header button. I do not, I see a big fat zero. If I click on the subscribed list I get the message

‘Invalid database query’ then on the next lines

‘List of currently subscribed topics’

‘You are not currently subscribed to any topics’

I guess the first line is the important one and it was remiss of me not to notice it sooner!

I do not get any errors or warnings in the FF error console when running this.

This occurs with revision 6855 and the default theme.

Ah well – the ‘Invalid Database Query’ is probably the important bit there. That I can look into…
Ticket opened – thanks for the detail.

Politely asks have you been able to re-create this at all Andy?

Actually Steve is on this one and just checking its status I see that so far he has not.
Is there any more information you can give us?

What would you like ideally? I have a clean and up to date installation, I don’t get any errors when I click the ‘subscribed’ button. I don’t know what else I can offer you. How can I check what query is being run on the DB?

Perhaps the structure is wrong some how?

Is there anything that I can check?

Busy at work this week so don’t expect to be quite so active.

Yes try this for me if you would.

Go to the forum admin > Toolbox > Error Log. Scroll to the bottom and clear the current errors and there will be some.

Go back to the front end and force the error with the DB query.

Go back to the error log – and there should be an entry regarding the DB query failure. Can you send me the error text shown there?

August 16, 2011

11:41 am database file: /problem-with-post-edit-buttonome/gruzcom1/public_html/ABF_Test/wp-content/sp-resources/forum-plugins/subscriptions/library/sp-subscriptions-database.php

line: 223

function: select

error: Unknown column ‘blog_post_id’ in ‘field list’

SELECT abf_test_sftopics.topic_id, topic_slug, topic_name, topic_date, topic_status, topic_pinned, topic_opened, topic_subs, topic_status_flag, blog_post_id, abf_test_sftopics.forum_id, abf_test_sftopics.post_id, abf_test_sftopics.post_count, forum_slug, forum_name, topic_status_set, group_id, post_content, post_status, post_date FROM abf_test_sftopics JOIN abf_test_sfforums ON abf_test_sfforums.forum_id = abf_test_sftopics.forum_id JOIN abf_test_sfposts ON abf_test_sftopics.post_id = abf_test_sfposts.post_id WHERE abf_test_sftopics.topic_id IN (1,13,22,21,25,23,29,28,26) ORDER BY topic_date DESC

So ‘blog_post_id’ should not be there, I guess that this is generated by another plugin? I’ll see if I can figure out what.

Conrad

Ah – that’s all I need. Thanks. Ticket opened with these details.
Great…

Sounds good to me, I will passively wait for a cure.

huh?  the fix was committed on the 21st…  are you still getting the error???

Nope the errors have gone and the subscribe plug-in appears to be working .I have not been very active w, I’ll be playing catch-up this week. I now have 6945 installed and need to figure out what has been done.