Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
plugins-topic
Subscribe plug in
Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Aug 2, 2011 - 2:26 pm
The subscribe to topic button is not working for me. I get an error message, the master subscribe list at the top of the forum does not increment, but the button itself changes state from subscribe to unsubscribe.

The error is:

Warning: Missing argument 4 for sp_build_url(), called in /problem-with-post-edit-buttonome/gruzcom1/public_html/ABF_Test/wp-content/sp-resources/forum-plugins/subscriptions/library/sp-subscriptions-components.php on line 172 and defined in /problem-with-post-edit-buttonome/gruzcom1/public_html/ABF_Test/wp-content/plugins/simple-press/sp-api/sp-api-permalinks.php on line 48

 

Anyone else?

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Aug 3, 2011 - 12:06 am

yup confirmed...  best thing about alpha versions...  fixing or adding stuff always seems to break stuff that has been working... [Image Can Not Be Found]

ticket open...

Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Aug 9, 2011 - 4:11 pm

Some movement on this and I thought that you would like to know.

When the subscribe button is activated in the editor I no longer see any error script pop up. In addition I am getting email notification upon subscription. The button next to the RSS button at the bottom in topic view is toggling subscribe/unsubscribe and is functioning correctly.

In the editor options when you are subscribed to a topic the message 'Unsubscribe from this topic' appears but the indicator is on green when you are subscribed - this is counter intuitive and I am pretty is sure not what you intended. I would expect the message to appear but be on red for not selected. Changing it to green should unsubscribe I would have thought. If the green indicator for 'Unsubscribe from this topic' is left alone then no action results.

Conversely if you are not subscribed and open an edit window then the 'subscribe to this topic' message appears and behaves exactly as expected. It appears with the red indicator on and changing the indicator to green results in a successful subscription.

Finally in the header the Subscribed X with the 'Review subscribed topics' tooltip just does not work. There are never any topics to review when I click on this link.

This is at svn up 6855

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 9, 2011 - 4:25 pm

All sounds good... Thanks for the feedback as usual.

Green just means 'on' or 'select this option'. Red means turn it off. So isn't that right? By unsubscribing am I not turning something off?

When you say the Subscribed button in the header 'just does not work' can you give a little more detail? Remember this is only going to report when there is a new post in a topic you are subscribed to but there should at least be a message when you click on it if there are no unread posts...

andy-signature.png
YELLOW
SWORDFISH
Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Aug 9, 2011 - 8:05 pm

Mmmm I think that we disagree about the unsubscribe indicator light. The message says 'Unsubscribe from this topic'  and I would expect the green light to be affirmation that you want to Unsubscribe just as a green light is affirmation that you want to subscribe when you are not subscribed to that topic. That would then be consistent.

When I say just does not work I mean that I cannot see any useful function from it at all. Surely it should have a list of subscribed topics then when the list is opened there should be a flag or something similar that indicates whether there are new posts there on each individual subscribed topic.

However if I understand you correctly then it is not working how you describe either.

I log on as MemberA and post something in a topic called 'subscribe test'. Member B, another user, is subscribed to that topic but is currently not logged in. I log in as Member B on another browser and would expect to see at least Subscribed 1 in the header button. I do not, I see a big fat zero. If I click on the subscribed list I get the message

'Invalid database query' then on the next lines

'List of currently subscribed topics'

'You are not currently subscribed to any topics'

I guess the first line is the important one and it was remiss of me not to notice it sooner!

I do not get any errors or warnings in the FF error console when running this.

This occurs with revision 6855 and the default theme.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 10, 2011 - 4:54 am

Ah well - the 'Invalid Database Query' is probably the important bit there. That I can look into...
Ticket opened - thanks for the detail.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Aug 15, 2011 - 4:43 pm

Politely asks have you been able to re-create this at all Andy?

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 15, 2011 - 5:02 pm

Actually Steve is on this one and just checking its status I see that so far he has not.
Is there any more information you can give us?

andy-signature.png
YELLOW
SWORDFISH
Avatar
Conrad_Farlow
Sheffield, UK
Member
Free Members
sp_UserOfflineSmall Offline
Aug 15, 2011 - 5:30 pm

What would you like ideally? I have a clean and up to date installation, I don't get any errors when I click the 'subscribed' button. I don't know what else I can offer you. How can I check what query is being run on the DB?

Perhaps the structure is wrong some how?

Is there anything that I can check?

Busy at work this week so don't expect to be quite so active.

Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Aug 16, 2011 - 4:44 am

Yes try this for me if you would.

Go to the forum admin > Toolbox > Error Log. Scroll to the bottom and clear the current errors and there will be some.

Go back to the front end and force the error with the DB query.

Go back to the error log - and there should be an entry regarding the DB query failure. Can you send me the error text shown there?

andy-signature.png
YELLOW
SWORDFISH
Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 649
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 618
Members: 17356
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10122
Posts: 79610