Support Forum

Simple:Press 6 Theme Topics

Able to add ID to sp_SectionStart()?

Page: 1 2

Able to add ID to sp_SectionStart()?

Lee H

Coastal New England (USA)

Member

Free Members

Offline

Sep 14, 2011 - 5:48 pm

Holy Crap Andy! I checked the diff of your commit. What a pain! Thanks so much. Looks great and as I was hoping on the mentioned functions, and you took it all the way to the bottom of the file.

I'll get a chance to play with the code later tonight. I'm sure it will do what I was hoping. Hopefully my bright idea didn't break anything laugh

Lee H

Coastal New England (USA)

Member

Free Members

Offline

Sep 15, 2011 - 8:22 am

I've a question about the function. I didn't notice before. But in the switch...

Is the switch default line incorrectly written? Or is it intentional that $sectionName have the string "default" to work?

Currently it's written as this:

        case 'default': 
            if(!empty($tagId)) $rowId=$tagId; 
            break; 
    }

or should it be this?

        default: 
            if(!empty($tagId)) $rowId=$tagId; 
            break; 
    }

Yellow Swordfish

Glinton, England

SP Master

Offline

Sep 15, 2011 - 11:09 am

Ho ho but yes that looks wrong...

Or is it..... I will need to investigate as Steve did this but we might pass in the term 'default' which would make this right.

YELLOW

SWORDFISH

Yellow Swordfish

Glinton, England

SP Master

Offline

Sep 15, 2011 - 12:59 pm

Steve - you are going to have to chime in on this one...

As far as I can tell this is an error - unless you are passing the actual term 'default' from somewhere I have not found. You did most of the default handling so I need you to verify.

YELLOW

SWORDFISH

Lee H

Coastal New England (USA)

Member

Free Members

Offline

Sep 15, 2011 - 1:07 pm

Either way works for me. I'll hold tight until Steve gives his two cents 🙂

Edit: Forgot to add it "may" be intentional as it appears in sp_ColumnStart as well. Though I am completely lost in it's purpose?