Support Forum

Advanced Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
themes-topic
Able to add ID to sp_SectionStart()?
Avatar
Lee H
Coastal New England (USA)
Member
Free Members
sp_UserOfflineSmall Offline
Sep 14, 2011 - 5:48 pm

Holy Crap Andy! I checked the diff of your commit. What a pain! Thanks so much. Looks great and as I was hoping on the mentioned functions, and you took it all the way to the bottom of the file.

I'll get a chance to play with the code later tonight. I'm sure it will do what I was hoping. Hopefully my bright idea didn't break anything laugh

Avatar
Lee H
Coastal New England (USA)
Member
Free Members
sp_UserOfflineSmall Offline
Sep 15, 2011 - 8:22 am

I've a question about the function. I didn't notice before. But in the switch...

Is the switch default line incorrectly written? Or is it intentional that $sectionName have the string "default" to work?

Currently it's written as this:

        case 'default': 
            if(!empty($tagId)) $rowId=$tagId; 
            break; 
    }

or should it be this?

        default: 
            if(!empty($tagId)) $rowId=$tagId; 
            break; 
    }
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Sep 15, 2011 - 11:09 am

Ho ho but yes that looks wrong...

Or is it..... I will need to investigate as Steve did this but we might pass in the term 'default' which would make this right.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Yellow Swordfish
Glinton, England
SP Master
sp_UserOfflineSmall Offline
Sep 15, 2011 - 12:59 pm

Steve - you are going to have to chime in on this one...

As far as I can tell this is an error - unless you are passing the actual term 'default' from somewhere I have not found. You did most of the default handling so I need you to verify.

andy-signature.png
YELLOW
SWORDFISH
Avatar
Lee H
Coastal New England (USA)
Member
Free Members
sp_UserOfflineSmall Offline
Sep 15, 2011 - 1:07 pm

Either way works for me. I'll hold tight until Steve gives his two cents 🙂

Edit: Forgot to add it "may" be intentional as it appears in sp_ColumnStart as well. Though I am completely lost in it's purpose?

Avatar
Mr Papa
Simi Valley, CA
SP Master
Free Members
sp_UserOfflineSmall Offline
Sep 16, 2011 - 10:59 pm

hmmmm...  this topic was not showing up unread yesterday but does today...

No, that is wrong... should be default:

its so plugins or theme can hook into the section or column...

opening ticket...

Forum Timezone: Europe/Stockholm
Most Users Ever Online: 1170
Currently Online:
Guest(s) 1
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Mr Papa: 19448
Ike: 2086
Brandon: 864
kvr28: 804
jim: 650
FidoSysop: 577
Conrad_Farlow: 531
fiddlerman: 358
Stefano Prete: 325
Member Stats:
Guest Posters: 619
Members: 17364
Moderators: 0
Admins: 4
Forum Stats:
Groups: 7
Forums: 17
Topics: 10127
Posts: 79625