Support Forum
Support Forum
Offline
PS: This is the Desktop template. Mobile spHead file does not seem to have any ShareThis tag.
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
Offline
Hey Jim,
This is a bit strange and not quite sure how the forum here doesn't have the same problem. I'll take a look at it in the morning as it's getting pretty late here (or early!).
You should just be able to remove line 25 in the spGroupView.php template.
Offline
Thanks Ike, got my child theme all set up and removed the ShareThis tag from Group view, keeping it in spHead, to show in other views.
A bit off track... but I might suggest one edit to the Child Theme instructions to clarify that the "root" template files (the ones that call Mobile or Desktop templates) must also be moved to the child's /templates folder.
Instructions say to only include modified files. I couldn't figure out why my child templates weren't loading until I copied the unchanged parent template files to /child/templates and the modified templates to /child/templates/desktop (or /mobile).
Otherwise, very clear and thorough write-up. Thanks for all the effort!
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
Offline
we have only realized that in the last day or so ourselves... reboot was the first theme to break up the desktop and mobile like that... so your suggestion only applies to reboot currently, but we will come up with way to address...
Visit Cruise Talk Central and Mr Papa's World
Offline
OK, a couple things here I've noticed since updating to Reboot 1.0.1...
I'm trying to keep my child theme with as few edits as possible, so I wonder if these issues might be addressed in the next parent release.
1. I temporarily disabled my child Group View and notice there are still multiple Share This buttons. One for every group. The links shared all go to the same page. Only one is necessary atop all the groups, or perhaps it belongs back in the Head....
2. I have no modified Topic View template in my child theme for any device. There are two Share This buttons at the top of the topic, above all posts. The shared links generated are different, but they both direct to the same topic page...
3. In the screenshot above, I also point out the floating Share This button that appears at the bottom of the mobile screen. We have a #top button that tends to cover it up and cause problems with a user clicking one or the other. Yes, I know I can move my button up but that would cause clutter and I just believe that floating button is redundant when share links appear above the forums.
First question: Any way to disable that floating button? I saw no option in the plugin options. Does it have its own template tag/call?
4. Forum View appears to be fine, with one share button atop all the topics. Except that is too has the redundant floating button, which I understand some people may prefer...
5. While editing files to modify my child theme, I noticed a consistent problem with many Reboot theme files. It may not be causing any issues, but I just downloaded a freash copy and confirmed that all /mobile and most /desktop templates reference the Unified theme, not Reboot. For example...
# Simple:Press Template # Theme : Unified # Template : foot # Author : Simple:Press
All the files in the root theme direcory seem to have the correct theme name, but I did notice that all the PM templates do not reference any theme, if they are supposed to.
NOTE: Hopefully the next Reboot update will also correct the capitalization of the /Reboot directory name so child framework themes don't break when it is updated. They call the Parent: Reboot (not: reboot)
Sorry for all this, but I hope I'm being clear and I hope it helps. Thanks!
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
Offline
Hey Jim,
Are we talking about mobile specifically here? I know some of the issues affect both but notice that the screenshots you've attached are mobile= - I'll go through them in the same order:
1. This one is a little confusing, I've checked my local spGroupViewMobile.php which only contains one ShareThis button in the header, and have also checked v.1.0.1 which also only has one. Not sure how you have one in each group and one in the header - This was behaviour seen in spGroupViewDesktop.php in version 1.0.1 but has been fixed for 1.0.2.
2. There is a ticket open for this and it will be fixed for 1.0.2
3 & 4. I've got to be honest, that doesn't look like our Share button and I don't think we have a floating one - There's definitely no option for it in the plugin settings and no reference to anything like that in the templates - Maybe Steve or Andy could just confirm that as I didn't write the plugin. Any chance you could inspect it and find out what it's called?
5. Well spotted 🙂 I'm not sure how these slipped through but somehow did.. Reboot was built from Unified so naturally began with the same templates. It shouldn't matter as I'm pretty sure the template titles at the top there are purely for reference. I'll make sure they are cleaned up regardless so thanks for pointing that out!
The PM templates don't reference any theme as technically they are plugin templates, but due to the way Reboot utilises CSS3 it was necessary to include them.
Also, it looks like the child theme framework has already been updated to read 'reboot'. It's not tied in with Reboot releases so I'm guessing it has been done quickly to try and reduce the amount of problems.
Also no need to apologise, the more we know that is at fault the quicker we can bring it up to standard, which is of course the aim! A couple of issues brought to us in other threads have existed for over half a year without any of us noticing, but there's only so much you can test between three of us. Getting feedback from the community is vital!
Offline
Ike said
Are we talking about mobile specifically here?
Yes. I have the same Reboot child theme activated for all devices now. But I'm specifically referring to Mobile view.
1. This one is a little confusing...
Sure is, I only noticed and reported it after disabling my child/mobile/spGroupViewMobile.php template which includes no Share This tags. I have no edited spHead in my child.
2. There is a ticket open for this and it will be fixed for 1.0.2
Great!
3 & 4. I've got to be honest, that doesn't look like our Share button and I don't think we have a floating one...
Just to be clear, I'm referring to the round grey Share This button partially hidden behind my round yellow #top link with the orange arrow. Unfortunately, neither are loading in the Chrome mobile emulation and it doesn't appear in Desktop view so I can't inspect it. Screen shot of the floating button before it gets hidden by my #top button is at the bottom of this post. (My button loads only after scrolling down600px.)
5. ...Reboot was built from Unified so naturally began with the same templates.
I figured that much. An honest mistake, we'll forgive you. 
The PM templates don't reference any theme as technically they are plugin templates
Thought so. Thanks for confirming!
Also, it looks like the child theme framework has already been updated to read 'reboot'.
I'll need to rename my /Reboot directory to /reboot then, and update my child theme. Guess I made the wrong edit to make it work, but chances were 50/50. Thanks for letting me know!
Getting feedback from the community is vital!
For sure. Happy to help any way I can!
*Share This button...no similar image found in the plugin /images folder. 
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
Offline
I will leave most of this for Ike to address but I will weigh in on the round, grey 'share this' button and echo his comment that this doesn't appear to be ours. Unless you changed all the graphics we don't supply any round ones and from the rest of the shots you use the rectangular green standard button by default.
I am having trouble working out quite where it is in the display as well. Had a look at the site this morning (the test server you linked us to) and don't see them.
 |
YELLOW
SWORDFISH
|
Offline
perhaps you are using another share this plugin for wp? and its adding its own thing to the forum too?
Visit Cruise Talk Central and Mr Papa's World
Offline
Yellow Swordfish said
Had a look at the site this morning (the test server you linked us to) and don't see them.
My bad. I must've got confused, this is occurring on our live site, or it was...
I realized it may have been the Shareaholic plugin showing the floating button. But that was not the case. I confirmed it only appeared on the Forums page. I then confirmed that it went away after deactivating the SP Share This plugin. But upon reactivation it is now still gone. Perhaps a remnant from a previous version. Who knows...I'm blaming this one on the Gremlins.
Simple:Press powers the Tripawds Discussion Forums.
It's better to hop on three legs than to limp on four.
The Tripawds Blogs Community is made possible by The Tripawds Foundation.
All RSS1 Guest(s)